ra/runelite
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

kourendlibrary: remove unneeded hidden flag from overlay

Browse Source 
From testing, this flag didn't seem to do anything useful.
It might have also led to certain users thinking that the plugin was broken if they had enabled the plugin after the client was started.
This commit is contained in:
Hydrox6
2019-11-25 12:22:47 +00:00
parent 09da86884a
commit 76fdb50fa6
2 changed files with 0 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
runelite-client/src/main/java/net/runelite/client/plugins/kourendlibrary/KourendLibraryOverlay.java
View File

@@ -36,8 +36,6 @@ import java.util.Objects;
import java.util.Set;
import java.util.stream.Collectors;
import javax.annotation.Nullable;
import lombok.AccessLevel;
import lombok.Setter;
import net.runelite.api.Client;
import net.runelite.api.Perspective;
import static net.runelite.api.Perspective.getCanvasTilePoly;
@@ -58,9 +56,6 @@ class KourendLibraryOverlay extends Overlay
private final KourendLibraryConfig config;
private final KourendLibraryPlugin plugin;
@Setter(AccessLevel.PACKAGE)
private boolean hidden;
@Inject
private KourendLibraryOverlay(Library library, Client client, KourendLibraryConfig config, KourendLibraryPlugin plugin)
{
@@ -76,11 +71,6 @@ class KourendLibraryOverlay extends Overlay
@Override
public Dimension render(Graphics2D g)
{
if (hidden)
{
return null;
}
Player player = client.getLocalPlayer();
if (player == null)
{

3
runelite-client/src/main/java/net/runelite/client/plugins/kourendlibrary/KourendLibraryPlugin.java
View File

@@ -141,7 +141,6 @@ public class KourendLibraryPlugin extends Plugin
@Override
protected void shutDown()
{
overlay.setHidden(true);
overlayManager.remove(overlay);
overlayManager.remove(tutorialOverlay);
clientToolbar.removeNavigation(navButton);
@@ -187,7 +186,6 @@ public class KourendLibraryPlugin extends Plugin
if (MenuAction.GAME_OBJECT_FIRST_OPTION == menuOpt.getMenuAction() && menuOpt.getMenuTarget().contains("Bookshelf"))
{
lastBookcaseClick = WorldPoint.fromScene(client, menuOpt.getActionParam(), menuOpt.getWidgetId(), client.getPlane());
overlay.setHidden(false);
}
}
@@ -273,7 +271,6 @@ public class KourendLibraryPlugin extends Plugin
return;
}
overlay.setHidden(false);
library.setCustomer(cust, book);
panel.update();
}