From 76fdb50fa682b32e6c0544db39c2bb927aca55c4 Mon Sep 17 00:00:00 2001 From: Hydrox6 Date: Mon, 25 Nov 2019 12:22:47 +0000 Subject: [PATCH] kourendlibrary: remove unneeded hidden flag from overlay From testing, this flag didn't seem to do anything useful. It might have also led to certain users thinking that the plugin was broken if they had enabled the plugin after the client was started. --- .../plugins/kourendlibrary/KourendLibraryOverlay.java | 10 ---------- .../plugins/kourendlibrary/KourendLibraryPlugin.java | 3 --- 2 files changed, 13 deletions(-) diff --git a/runelite-client/src/main/java/net/runelite/client/plugins/kourendlibrary/KourendLibraryOverlay.java b/runelite-client/src/main/java/net/runelite/client/plugins/kourendlibrary/KourendLibraryOverlay.java index a98acf39ff..682aee3ace 100644 --- a/runelite-client/src/main/java/net/runelite/client/plugins/kourendlibrary/KourendLibraryOverlay.java +++ b/runelite-client/src/main/java/net/runelite/client/plugins/kourendlibrary/KourendLibraryOverlay.java @@ -36,8 +36,6 @@ import java.util.Objects; import java.util.Set; import java.util.stream.Collectors; import javax.annotation.Nullable; -import lombok.AccessLevel; -import lombok.Setter; import net.runelite.api.Client; import net.runelite.api.Perspective; import static net.runelite.api.Perspective.getCanvasTilePoly; @@ -58,9 +56,6 @@ class KourendLibraryOverlay extends Overlay private final KourendLibraryConfig config; private final KourendLibraryPlugin plugin; - @Setter(AccessLevel.PACKAGE) - private boolean hidden; - @Inject private KourendLibraryOverlay(Library library, Client client, KourendLibraryConfig config, KourendLibraryPlugin plugin) { @@ -76,11 +71,6 @@ class KourendLibraryOverlay extends Overlay @Override public Dimension render(Graphics2D g) { - if (hidden) - { - return null; - } - Player player = client.getLocalPlayer(); if (player == null) { diff --git a/runelite-client/src/main/java/net/runelite/client/plugins/kourendlibrary/KourendLibraryPlugin.java b/runelite-client/src/main/java/net/runelite/client/plugins/kourendlibrary/KourendLibraryPlugin.java index 46abbec99e..dbc19fdf63 100644 --- a/runelite-client/src/main/java/net/runelite/client/plugins/kourendlibrary/KourendLibraryPlugin.java +++ b/runelite-client/src/main/java/net/runelite/client/plugins/kourendlibrary/KourendLibraryPlugin.java @@ -141,7 +141,6 @@ public class KourendLibraryPlugin extends Plugin @Override protected void shutDown() { - overlay.setHidden(true); overlayManager.remove(overlay); overlayManager.remove(tutorialOverlay); clientToolbar.removeNavigation(navButton); @@ -187,7 +186,6 @@ public class KourendLibraryPlugin extends Plugin if (MenuAction.GAME_OBJECT_FIRST_OPTION == menuOpt.getMenuAction() && menuOpt.getMenuTarget().contains("Bookshelf")) { lastBookcaseClick = WorldPoint.fromScene(client, menuOpt.getActionParam(), menuOpt.getWidgetId(), client.getPlane()); - overlay.setHidden(false); } } @@ -273,7 +271,6 @@ public class KourendLibraryPlugin extends Plugin return; } - overlay.setHidden(false); library.setCustomer(cust, book); panel.update(); }