Commit Graph

4651 Commits

Author SHA1 Message Date
Max Weber
87bf71c1ff mixins: Prevent runScript from being called recursively
Due to the extensive use of globals in the ScriptVM it is not reentrant
2018-07-24 18:25:40 -06:00
Adam
23c13c1d53 cache: fix assembler to set correct switch table index
The int operand of switch instructions is an index into the switch table. The operand was always 0, breaking scripts with multiple switches.
2018-07-24 20:12:34 -04:00
Tomas Slusny
7831042189 Merge pull request #4447 from deathbeam/do-not-reconfigure
Update frame config when needed
2018-07-24 11:52:13 +02:00
Tomas Slusny
28dd5f477c Update frame config when needed
Update resizable only when it is really changed as it messes up window
sometimes if fullscreen

Signed-off-by: Tomas Slusny <slusnucky@gmail.com>
2018-07-24 11:41:10 +02:00
Adam
7bbb154dff Merge pull request #2251 from marshdevs/2123-diary-level-requirements
Add level requirements to diaries
2018-07-23 17:50:06 -04:00
Adam
5c920f9414 Add achievement diary plugin
This adds skill level requirements to the achievement diary log.
2018-07-23 10:59:15 -04:00
Adam
25ab36d56e Merge runelite-scripts into runelite-client 2018-07-22 19:59:54 -04:00
Adam
37c95ff75e Add private message input event and add !kc to chatcommands for private messages 2018-07-22 19:44:10 -04:00
Abex
1d31796fc5 Merge pull request #4350 from Abextm/hotkey-consumer
runelite-client: Consume hotkeys in HotkeyListener
2018-07-22 14:36:24 -06:00
Adam
14707ba202 Merge pull request #4429 from deathbeam/add-movable-widgets
Add support for movable RS widgets
2018-07-22 14:23:28 -04:00
Adam
3f30e5ebb0 Merge pull request #4442 from Adam-/master+minimap
Fix plugins rendering over hidden minimap
2018-07-22 12:30:18 -04:00
Tomas Slusny
a3ddd47a29 Add support for RS movable widgets
Add support for adding RS widgets to RuneLite overlay system and make
them moveable with persisted positions during restarts.

Depends on #3820 for widget ids

Signed-off-by: Tomas Slusny <slusnucky@gmail.com>
2018-07-22 18:25:00 +02:00
Tomas Slusny
2627f08f18 Add experience tracker widget WidgetInfo
Signed-off-by: Tomas Slusny <slusnucky@gmail.com>
2018-07-22 18:25:00 +02:00
Tomas Slusny
84473262ba Use Overlay#getBounds for getting correct bounds
Use Overlay#getBounds for getting correct bounds in OverlayManager in
case overlay overrides getBounds with custom functionality.

Signed-off-by: Tomas Slusny <slusnucky@gmail.com>
2018-07-22 18:25:00 +02:00
Tomas Slusny
d700ebc257 Add support for resetting the detached overlays
Add support for resetting saved data for detached overlays.

Signed-off-by: Tomas Slusny <slusnucky@gmail.com>
2018-07-22 18:25:00 +02:00
Adam
381696fddd perspective: account for minimap being hidden or moved in worldToMiniMap 2018-07-22 12:13:09 -04:00
Adam
0297f7684c mixins: optimize widget isHidden and getParent 2018-07-22 12:13:09 -04:00
Adam
630a3947da mixins: only update render parent of nested widget if widget would have been rendererd 2018-07-22 12:13:09 -04:00
Adam
2942b25e5d runelite-api: add fixed minimap widgets 2018-07-22 12:13:09 -04:00
Adam
4d98c63168 Merge pull request #3820 from deathbeam/fix-resizable-minimap
Use correct widget when hiding resizable minimap
2018-07-21 21:29:15 -04:00
Adam
5c1028817e Merge pull request #4399 from Abextm/map-clue-description
cluescrolls: Add description to map clues
2018-07-21 20:50:04 -04:00
John Pettenger
8943d1d106 timers plugin: add abyssal sire stun timer 2018-07-21 20:31:55 -04:00
Adam
899ad1c78a Merge pull request #3668 from deathbeam/improve-client-creation
Improve client creation
2018-07-21 20:25:35 -04:00
Tomas Slusny
cda98fc50e Move Discord and EventBus after ClientUI
Move initialization of Discord service and EventBus after ClientUI
startup to display the ClientUI sooner

Signed-off-by: Tomas Slusny <slusnucky@gmail.com>
2018-07-21 23:09:08 +02:00
Tomas Slusny
af34aa0e53 Properly load configuration when showing ClientUI
- Properly load configuration when first showing ClientUI instead of
waiting for ConfigChanged events.
- Merge open and show to 1 method
- Remove ClientUILoaded as it is no longer necessary

Signed-off-by: Tomas Slusny <slusnucky@gmail.com>
2018-07-21 23:09:08 +02:00
Tomas Slusny
53148d0cdd Remove recursive dependency on RuneLite
- Merge ClientUI.show and ClientUI.init as now applet can be properly
injected
- Change RuneLite to be autocloseable and send it when opening ClientUI

Signed-off-by: Tomas Slusny <slusnucky@gmail.com>
2018-07-21 23:09:07 +02:00
Tomas Slusny
66bfbc5648 Send launch properties around as bound constants
Instead of exposing static variable provide launch properties to
dependant classes as bound constants in RuneLiteModule.

Signed-off-by: Tomas Slusny <slusnucky@gmail.com>
2018-07-21 23:05:22 +02:00
Tomas Slusny
8909871554 Inject and load RS client and applet through Guice
Instead of requiring to create client from RuneLite just use Guice for
it and separate applet provider.

Signed-off-by: Tomas Slusny <slusnucky@gmail.com>
2018-07-21 23:05:22 +02:00
Tomas Slusny
0f0ac2ab64 Allow RS loading classes to be used with Guice
- Provide OkHttpClient through Guice instead of using it from static
variable
- Chain the RS classes with Guice and inject ClientLoader to RuneLite
class
- Cleanup RS loading classes a bit

Signed-off-by: Tomas Slusny <slusnucky@gmail.com>
2018-07-21 23:05:19 +02:00
Tomas Slusny
dcbccbb01b Move rs-client related classes to own package
To properly differentiate between client loading logic, move these
classes to own package.

Signed-off-by: Tomas Slusny <slusnucky@gmail.com>
2018-07-21 22:33:46 +02:00
Tomas Slusny
d646a37bdb Follow GitHub templates for bug report and issue (#4205)
Based on points made in #4160, update GitHub issue templates to be more
versatile, do not include any inline comments and be straightforward,
while pointing out reporter in correct direction. Also, one of the
crucial things that previous template for bug report was missing was
RuneLite and Launcher versions and steps to reproduce the bug.

Supersedes #4160

Signed-off-by: Tomas Slusny <slusnucky@gmail.com>
2018-07-21 18:33:47 +02:00
Tomas Slusny
7de8436bdb Merge pull request #4412 from deathbeam/pmod-support-chat
Add support for mod public chat to ChatCommands
2018-07-21 10:54:46 +02:00
Tomas Slusny
90853c91c8 Merge pull request #4417 from deathbeam/clan-member-rank-jmod
Add JMod clan member rank
2018-07-21 10:53:53 +02:00
Tomas Slusny
7c5e545846 Merge pull request #4436 from timovv/inventory-viewer-spacing
Inventory viewer: make padding between items same as in inventory.
2018-07-21 10:31:17 +02:00
Tomas Slusny
b861b7d706 Merge pull request #4432 from Nightfirecat/fix-sdmm-opponent-lookup
opponent info plugin: Fix SDMM hiscore lookup
2018-07-21 09:48:41 +02:00
Timo van Veenendaal
fa7403affa Inventory viewer: Fix vertical spacing of items to match inventory. 2018-07-21 16:13:58 +12:00
Timo van Veenendaal
175ec9d271 Inventory viewer: make padding between items same as in inventory.
Fixes #4136
2018-07-21 15:59:07 +12:00
Jordan Atwood
6c1aefc8d9 opponent info plugin: Fix SDMM hiscore lookup
SDMM worlds have both `DEADMAN` and `SEASONAL_DEADMAN` types, so we
must check for the latter first to accurately determine the hiscore
lookup endpoint.
2018-07-20 16:45:31 -07:00
Tomas Slusny
67bb02c42e Merge pull request #4430 from Joshua-F/fix/actorquery-interacting
Use the supplied actor passed to ActorQuery#isInteractingWith
2018-07-21 00:35:14 +02:00
Joshua Filby
fb0dc0c68c fix: use the supplied actor to check against in isInteractingWith 2018-07-20 17:07:03 -05:00
Tomas Slusny
d1ba793849 Hide only inside of minimap but not logout
In normal resizable mode hide only insides of minimap but not logout
button when hiding minimap.

Signed-off-by: Tomas Slusny <slusnucky@gmail.com>
2018-07-20 22:33:44 +02:00
Tomas Slusny
0002a25d28 Move private methods to bottom of minimap plugin
Move private methods to bottom, after subscribe methods for better
readability.

Signed-off-by: Tomas Slusny <slusnucky@gmail.com>
2018-07-20 22:13:04 +02:00
Tomas Slusny
26daee6a2e Use correct widget when hiding minimap
When hiding minimap, there are 2 different widget IDs for respective
resizable mode configurations. Find proper one and hide it.

Fixes #976

Signed-off-by: Tomas Slusny <slusnucky@gmail.com>
2018-07-20 22:13:04 +02:00
Tomas Slusny
4218459617 Add new WidgetIDs for minimap
Signed-off-by: Tomas Slusny <slusnucky@gmail.com>
2018-07-20 22:13:03 +02:00
Tomas Slusny
5249f73e54 Add JMod clan member rank
Signed-off-by: Tomas Slusny <slusnucky@gmail.com>
2018-07-19 23:27:38 +02:00
Tomas Slusny
0a4ce4cf4c Merge pull request #4388 from Kamielvf/tile-fix
perspective: fix regression caused by 2599db2
2018-07-19 21:32:01 +02:00
aquivers
aa6cb47a8c Add more chat !kc abbreviations (#4372)
Fixes #4396
2018-07-19 21:02:46 +02:00
Tomas Slusny
e19b057bdd Add support for mod public chat to ChatCommands
Without this chat commands were not working because it just exited
early for pmods.

Signed-off-by: Tomas Slusny <slusnucky@gmail.com>
2018-07-19 20:09:51 +02:00
Tomas Slusny
9fbe78e069 Merge pull request #4397 from Abextm/banana-plantation-clue
cluescrolls: Move banana plantation clue out of tree
2018-07-19 19:06:30 +02:00
Magic fTail
fd09843bb6 bank value plugin: add option to display exact value 2018-07-19 11:05:03 -04:00