This issue was caused by ground item values not being copied to
ArrayList when modified. To avoid unnecessary allocations, create new
copy only when required (e.g when holding alt).
Signed-off-by: Tomas Slusny <slusnucky@gmail.com>
When loaded and added in OverlayRenderer, it was too early to load their
properties because configuration was not loaded yet.
Fixes#3799
Signed-off-by: Tomas Slusny <slusnucky@gmail.com>
In ground items, consider anything that has positive GE value as
tradeable and exclude it from untradeable checks.
Signed-off-by: Tomas Slusny <slusnucky@gmail.com>
- Remove check for .add as for ArrayList it is always true and so it is
dead condition
- Add check for removeIf, so the overlay layers will be rebuilt only
when something is removed
Signed-off-by: Tomas Slusny <slusnucky@gmail.com>
- Generated equals from Lombok can cause falsy equals checks and so match
with unrelated overlay.
- Do not add overlay twice to overlay list based on equals
Signed-off-by: Tomas Slusny <slusnucky@gmail.com>
Instead of having the plugin enabled and everything inside disabled just
disable it and by default enable 1 option.
Signed-off-by: Tomas Slusny <slusnucky@gmail.com>
- To follow Konduit style a bit more, change the default size of infoboxes
to be somewhat around 24x24 instead of 36x36.
- Change the margin between infoboxes to 1px
Depends on #2874Closes#1771 and closes#1016
Signed-off-by: Tomas Slusny <slusnucky@gmail.com>
Instead of doing layouting by itself, use PanelComponent and newly added
support for component wrapping and disabling of background.
Signed-off-by: Tomas Slusny <slusnucky@gmail.com>
- Add support for storing preferredLocation in PanelComponent and
translate children based on it.
- Offset children in PanelComponent by metrics.getHeight by default
- Add null check for background in PanelComponent to support panels
without background
Signed-off-by: Tomas Slusny <slusnucky@gmail.com>
- Remove the usage of getOverlay and getOverlays
- Replace the overlay addition/removal with correct calls to
overlayManager.add and overlayManager.remove
- Update tests
Signed-off-by: Tomas Slusny <slusnucky@gmail.com>
- Split logic related to populating overlays to OverlayManager and
OverlayRenderer.
- Remove overlay-related logic from plugin, this is going to be handled
via OverlayManager.
- Inject core overlays to OverlayManager via new methods
Signed-off-by: Tomas Slusny <slusnucky@gmail.com>
- Add highlight > value setting
- Merge hide < GE and hide < HA value and always check for both
- Change the color getting logic to use simple methods instead of checks
spread around the code
Signed-off-by: Tomas Slusny <slusnucky@gmail.com>
