ra/runelite
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

Fix UnsupportedOperationException in ground items

Browse Source 
This issue was caused by ground item values not being copied to
ArrayList when modified. To avoid unnecessary allocations, create new
copy only when required (e.g when holding alt).

Signed-off-by: Tomas Slusny <slusnucky@gmail.com>
This commit is contained in:
Tomas Slusny
2018-06-15 17:05:06 +02:00
parent 62dc7c75c0
commit 459f126537
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
runelite-client/src/main/java/net/runelite/client/plugins/grounditems/GroundItemsOverlay.java
View File

@@ -31,6 +31,7 @@ import java.awt.FontMetrics;
import java.awt.Graphics2D;
import java.awt.Rectangle;
import java.util.AbstractMap.SimpleEntry;
import java.util.ArrayList;
import java.util.Collection;
import java.util.HashMap;
import java.util.Map;
@@ -107,11 +108,14 @@ public class GroundItemsOverlay extends Overlay
offsetMap.clear();
final LocalPoint localLocation = player.getLocalLocation();
final Point mousePos = client.getMouseCanvasPosition();
final Collection<GroundItem> groundItemList = plugin.getCollectedGroundItems().values();
Collection<GroundItem> groundItemList = plugin.getCollectedGroundItems().values();
GroundItem topGroundItem = null;
if (plugin.isHotKeyPressed())
{
// Make copy of ground items because we are going to modify them here, and the array list supports our
// desired behaviour here
groundItemList = new ArrayList<>(groundItemList);
final java.awt.Point awtMousePos = new java.awt.Point(mousePos.getX(), mousePos.getY());
GroundItem groundItem = null;