Commit Graph

3504 Commits

Author SHA1 Message Date
Levi Schuck
b52025ae72 Fix negative total XP calculation when skill starts
Closes #1734

Summary:
If you start a skill like fishing lobster after logging in,
you will have the xpGained value as `90`.
But, since you just started the skill, it will divide by `0`.
This results in the max integer value of `2147483647`.

If you did fletching before fishing, and had a XP per hour of `40000`.
Then when you add the fishing XP per hour of `2147483647`, the
result overflows and you get a negative number as the total XP per hour.

Solution:
Don't divide by zero, instead suppose that the skill has been active
for **at least** 60 seconds. This will result in a fair estimate that
improves as the skill continues to be used, rather than the ridiculous
estimate of 2 Billion one second and 200K the next second.

60 seconds is chosen over 1 or 5 or 10 seconds as the result is more
conservative and closer matches my hourly XP experiences.
2018-05-02 17:42:46 -05:00
Adam
8714544223 Merge pull request #2266 from deathbeam/verify-minum-size
Verify game's minimum size
2018-05-02 18:28:25 -04:00
Tomas Slusny
5a95a340cc Verify game's minimum size
Due to some race condition, we can't really rely on applet's minimum
size, so add verification for minimum size when size is changed.

Fixes: #2261

Signed-off-by: Tomas Slusny <slusnucky@gmail.com>
2018-05-02 22:00:45 +02:00
Tomas Slusny
7e8772dd7d Merge pull request #2101 from sethtroll/removeoppinfopadding
opponent info: reduce padding size
2018-05-02 20:37:50 +02:00
Mantautas Jurksa
eac09dbec9 Fix master fire cape emote clue 2018-05-02 19:50:16 +02:00
Adam
692443f7b3 Merge pull request #2244 from Nightfirecat/british-floor-numbering
Use British floor numbering in clue scroll hints
2018-05-02 13:11:02 -04:00
Jordan Atwood
9f1b6a6621 Use British floor numbering in clue scroll hints
Fixes runelite/runelite#2232
2018-05-01 19:04:14 -07:00
Adam
4a8eef023d Merge remote-tracking branch 'joshua/feat/accounttype' into next 2018-05-01 21:24:58 -04:00
Adam
24865f050f Merge remote-tracking branch 'kamiel/overhead-api-additions' into next 2018-05-01 21:24:44 -04:00
Adam
3f0782e83a Merge remote-tracking branch 'db/ground-item-only-right-click' into next 2018-05-01 21:24:28 -04:00
Adam
b87b0f3591 Merge remote-tracking branch 'abex/cli-args' into next 2018-05-01 21:24:05 -04:00
Adam
91b15deb4b Merge remote-tracking branch 'db/notification-mode' into next 2018-05-01 21:23:40 -04:00
Tomas Slusny
5904f3d924 Add 2 new notifications modes (message, flash)
- Change the notification mode selection to be dropdown
- Add chat message notification mode that will send game message on
notificiation
- Add screen flash notification that will flash screen for few ticks

Signed-off-by: Tomas Slusny <slusnucky@gmail.com>
2018-05-01 21:07:05 -04:00
Joshua Filby
b594c83ab6 feat: add a way to get AccountType
This adds a way to get the logged in players account type.
2018-05-01 21:00:54 -04:00
Adam
e9d1d7e75f devtools: post xp changed event too 2018-05-01 20:43:09 -04:00
Jordan Atwood
2e51181bc0 Allow "degree" and "minute" in coordinate clues
Fixes runelite/runelite#2233
2018-05-01 17:25:35 -07:00
Levi
443cc7569f xp tracker: rewrite tracking datastructures
Fix showing inaccurate "actions left" number #1735 
Fix tracker confusing switching accounts with xp gain #1273
2018-05-01 20:00:52 -04:00
Kamiel
a66c3fc6e7 Add 3rd Age Axe and 3rd Age Pickaxe animations to Idle Notifier 2018-05-01 19:38:01 -04:00
Adam
c3d59508f9 Merge pull request #2227 from Kamielvf/command-additions
Add anim, gfx and logger command to devtools
2018-05-01 19:37:23 -04:00
Kamiel
62deed7730 Add missing overhead icons to API 2018-05-01 19:32:57 -04:00
Kamiel
a7cbda46d8 Add logger command to change the logger level 2018-05-01 19:16:18 -04:00
Kamiel
e98304b536 Add gfx command to developer tools
Setting the spotAnimFrame to 0 is required to play the graphic from the start
2018-05-01 19:16:18 -04:00
Kamiel
084f8dcb64 Expose Actor graphic and spotAnimFrame to API 2018-05-01 19:16:17 -04:00
Kamiel
acfba42295 Add anim command to developer tools
It is required to set the action frame to 0 else the animation will not play from the beginning
2018-05-01 19:16:17 -04:00
Kamiel
f5ce1084d0 Expose Actor animation and actionFrame to API 2018-05-01 19:16:16 -04:00
Adam
55dbb706d8 Merge pull request #2190 from Berry-95/percentage-in-hiscores
Adds skill progress bar to hiscore panel
2018-05-01 18:34:10 -04:00
Jeroen
98ba85c92a Show missing fishing spots in Rellekka in overlay. 2018-05-02 00:08:28 +02:00
Samuel Beresford
a557fc7f25 Adds skill progress bar to hiscore panel
Matches existing progress bar (look&feel) as xp tracker
2018-05-01 18:00:53 -04:00
Adam
e5f010d75c Merge pull request #2189 from Rprrr/brothertranq
Brother Tranquility 'talk-to' & ''transport' option swap
2018-05-01 13:04:13 -04:00
Adam
2082010420 Merge pull request #2196 from NotFoxtrot/fix-master-clue-emote-entrana-church
Fix master clue emote: Entrana church
2018-05-01 12:17:04 -04:00
Adam
808260ecc8 Merge pull request #2206 from FatalWaffles/patch-1
Fix Beckon in Digsite clue location
2018-05-01 12:07:55 -04:00
Adam
63ec836dbf Merge pull request #2201 from Abextm/farm-tele
farmingtracker: Prevent saving when teleporting
2018-05-01 08:29:01 -04:00
Adam
b83cd1b7cd Merge pull request #2211 from millettmb/2210-low-hitpoints-notif-nmz
Improved low hp notif. by considering nmz absorption
2018-05-01 08:21:37 -04:00
u6077743
26ddd58da0 Improved low hp notif. by considering nmz absorption, 2210 2018-05-01 08:10:59 -04:00
FatalWaffles
67801c79cd Fix Beckon in Digsite location
Change worldpoint for Beckon in digsite location to be accurate.
2018-04-30 22:36:57 -04:00
Adam
618c16adca Merge pull request #2199 from Abextm/varpbsad
Refactor Vars
2018-04-30 20:21:30 -04:00
Max Weber
f3a8cd9ba9 farmingtracker: Prevent saving when teleporting
When teleporting to a updating region (ardy teleport), it would save the new region's varbits to the old region's config.
2018-04-30 18:14:59 -06:00
Adam
e648c426a2 Merge pull request #1907 from MESLewis/parameter-mapping
Add support for mapping parameter names
2018-04-30 19:49:53 -04:00
Adam
b150a7b535 Add maven-compiler-plugin to plugin management 2018-04-30 18:50:41 -04:00
Max Weber
efa67d7c93 Rename SettingsTracker 2018-04-30 16:27:52 -06:00
Max Weber
7f190f2534 Merge Varcs into Client::getVar 2018-04-30 16:17:04 -06:00
Max Weber
33d6b9bdb7 Rename Setting to VarPlayer 2018-04-30 16:03:49 -06:00
Maiddog
41342be02d Fix various clue objects and locations. 2018-04-30 17:17:01 -04:00
Max Weber
afebe6dbda runelite-client: Cleanup cli arguments 2018-04-30 15:12:29 -06:00
NotFoxtrot
e3ac212822 Fix master clue emote: Entrana church 2018-04-30 22:52:19 +02:00
Adam
dc1125a49c Merge pull request #2191 from NotFoxtrot/fix-elite-clue-cryptic-father-aereck
Fix cryptic elite clue: Father Aereck
2018-04-30 16:01:44 -04:00
Adam
1bf50fe194 Merge pull request #2143 from Nightfirecat/fix-shayzien-command-tent-emote-clue
Fix Shayzien command tent emote clue
2018-04-30 15:58:49 -04:00
NotFoxtrot
d1d394a259 Fix cryptic elite clue: Father Aereck 2018-04-30 20:37:31 +02:00
Rprrr
b7f62437be Fixes #2146 (Brother Tranquility 'talk-to' & ''transport' option swap w/Menu Swapper plugin) 2018-04-30 19:45:12 +02:00
Rprrr
31c27292e0 screenshot plugin: fix exception when taking screenshots on login 2018-04-30 12:48:51 -04:00