ra/runelite
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

cache: release the ByteBuf allocated when calling ByteBuf#readBytes(int)

Browse Source
This commit is contained in:
Joshua Filby
2018-02-19 10:16:18 -06:00
committed by Adam
parent 55a5eaa43d
commit ee35d32312
1 changed files with 14 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
protocol/src/main/java/net/runelite/protocol/update/encoders/ArchiveResponseEncoder.java
View File

@@ -55,14 +55,14 @@ public class ArchiveResponseEncoder extends MessageToByteEncoder<ArchiveResponse
// - 3 for the header // - 3 for the header
int chunkSize = Math.min(file.readableBytes(), CHUNK_SIZE - 3); int chunkSize = Math.min(file.readableBytes(), CHUNK_SIZE - 3);
out.writeBytes(file.readBytes(chunkSize)); writeChunk(file.readBytes(chunkSize), out);
while (file.isReadable()) while (file.isReadable())
{ {
out.writeByte(0xff); out.writeByte(0xff);
chunkSize = Math.min(file.readableBytes(), CHUNK_SIZE - 1); chunkSize = Math.min(file.readableBytes(), CHUNK_SIZE - 1);
out.writeBytes(file.readBytes(chunkSize)); writeChunk(file.readBytes(chunkSize), out);
} }
int size = out.readableBytes() - pos; int size = out.readableBytes() - pos;
@@ -71,4 +71,16 @@ public class ArchiveResponseEncoder extends MessageToByteEncoder<ArchiveResponse
archiveResponse.getData().length, size); archiveResponse.getData().length, size);
} }
private void writeChunk(ByteBuf chunk, ByteBuf out)
{
try
{
out.writeBytes(chunk);
}
finally
{
chunk.release();
}
}
} }