From ee35d3231240ff6065bae67579216d699a6d12e5 Mon Sep 17 00:00:00 2001
From: Joshua Filby <joshua@filby.me>
Date: Mon, 19 Feb 2018 10:16:18 -0600
Subject: [PATCH] cache: release the ByteBuf allocated when calling
 ByteBuf#readBytes(int)

---
 .../update/encoders/ArchiveResponseEncoder.java  | 16 ++++++++++++++--
 1 file changed, 14 insertions(+), 2 deletions(-)

diff --git a/protocol/src/main/java/net/runelite/protocol/update/encoders/ArchiveResponseEncoder.java b/protocol/src/main/java/net/runelite/protocol/update/encoders/ArchiveResponseEncoder.java
index 712a9a7767..06eb258115 100644
--- a/protocol/src/main/java/net/runelite/protocol/update/encoders/ArchiveResponseEncoder.java
+++ b/protocol/src/main/java/net/runelite/protocol/update/encoders/ArchiveResponseEncoder.java
@@ -55,14 +55,14 @@ public class ArchiveResponseEncoder extends MessageToByteEncoder<ArchiveResponse
 		// - 3 for the header
 		int chunkSize = Math.min(file.readableBytes(), CHUNK_SIZE - 3);
 
-		out.writeBytes(file.readBytes(chunkSize));
+		writeChunk(file.readBytes(chunkSize), out);
 
 		while (file.isReadable())
 		{
 			out.writeByte(0xff);
 
 			chunkSize = Math.min(file.readableBytes(), CHUNK_SIZE - 1);
-			out.writeBytes(file.readBytes(chunkSize));
+			writeChunk(file.readBytes(chunkSize), out);
 		}
 
 		int size = out.readableBytes() - pos;
@@ -71,4 +71,16 @@ public class ArchiveResponseEncoder extends MessageToByteEncoder<ArchiveResponse
 			archiveResponse.getData().length, size);
 	}
 
+	private void writeChunk(ByteBuf chunk, ByteBuf out)
+	{
+		try
+		{
+			out.writeBytes(chunk);
+		}
+		finally
+		{
+			chunk.release();
+		}
+	}
+
 }