ra/runelite
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

screenshot: Define more accurate method names and access levels

Browse Source
This commit is contained in:
SoyChai
2018-04-08 12:04:40 +10:00
committed by Adam
parent 851637c8b7
commit deb70796da
2 changed files with 12 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
runelite-client/src/main/java/net/runelite/client/plugins/screenshot/ScreenshotPlugin.java
View File

@@ -342,7 +342,7 @@ public class ScreenshotPlugin extends Plugin
* with the format "Your Skill (level is/are) now 99." * with the format "Your Skill (level is/are) now 99."
* @return Shortened string in the format "Skill(99)" * @return Shortened string in the format "Skill(99)"
*/ */
public String parseLevelUpWidget(WidgetInfo levelUpLevel) String parseLevelUpWidget(WidgetInfo levelUpLevel)
{ {
Widget levelChild = client.getWidget(levelUpLevel); Widget levelChild = client.getWidget(levelUpLevel);
if (levelChild == null) if (levelChild == null)

22
runelite-client/src/test/java/net/runelite/client/plugins/screenshot/ScreenshotPluginTest.java
View File

@@ -64,14 +64,14 @@ public class ScreenshotPluginTest
@Mock @Mock
@Bind @Bind
Client client; private Client client;
@Inject @Inject
ScreenshotPlugin screenshotPlugin; private ScreenshotPlugin screenshotPlugin;
@Mock @Mock
@Bind @Bind
ScreenshotConfig screenshotConfig; private ScreenshotConfig screenshotConfig;
@Mock @Mock
@Bind @Bind
@@ -83,7 +83,7 @@ public class ScreenshotPluginTest
@Mock @Mock
@Bind @Bind
OverlayRenderer overlayRenderer; private OverlayRenderer overlayRenderer;
@Mock @Mock
@Bind @Bind
@@ -102,7 +102,7 @@ public class ScreenshotPluginTest
} }
@Test @Test
public void testcluescroll() public void testClueScroll()
{ {
ChatMessage chatMessageEvent = new ChatMessage(SERVER, "Seth", CLUE_SCROLL, null); ChatMessage chatMessageEvent = new ChatMessage(SERVER, "Seth", CLUE_SCROLL, null);
screenshotPlugin.onChatMessage(chatMessageEvent); screenshotPlugin.onChatMessage(chatMessageEvent);
@@ -112,7 +112,7 @@ public class ScreenshotPluginTest
} }
@Test @Test
public void testbarrowschest() public void testBarrowsChest()
{ {
ChatMessage chatMessageEvent = new ChatMessage(SERVER, "Seth", BARROWS_CHEST, null); ChatMessage chatMessageEvent = new ChatMessage(SERVER, "Seth", BARROWS_CHEST, null);
screenshotPlugin.onChatMessage(chatMessageEvent); screenshotPlugin.onChatMessage(chatMessageEvent);
@@ -121,7 +121,7 @@ public class ScreenshotPluginTest
} }
@Test @Test
public void testraidschest() public void testRaidsChest()
{ {
ChatMessage chatMessageEvent = new ChatMessage(SERVER, "Seth", RAIDS_CHEST, null); ChatMessage chatMessageEvent = new ChatMessage(SERVER, "Seth", RAIDS_CHEST, null);
screenshotPlugin.onChatMessage(chatMessageEvent); screenshotPlugin.onChatMessage(chatMessageEvent);
@@ -130,7 +130,7 @@ public class ScreenshotPluginTest
} }
@Test @Test
public void testHitpoints() public void testHitpointsLevel99()
{ {
Widget widget = mock(Widget.class); Widget widget = mock(Widget.class);
when(widget.getId()).thenReturn(PACK(LEVEL_UP_GROUP_ID, 0)); when(widget.getId()).thenReturn(PACK(LEVEL_UP_GROUP_ID, 0));
@@ -150,7 +150,7 @@ public class ScreenshotPluginTest
} }
@Test @Test
public void testFiremaking() public void testFiremakingLevel9()
{ {
Widget widget = mock(Widget.class); Widget widget = mock(Widget.class);
when(widget.getId()).thenReturn(PACK(LEVEL_UP_GROUP_ID, 0)); when(widget.getId()).thenReturn(PACK(LEVEL_UP_GROUP_ID, 0));
@@ -170,7 +170,7 @@ public class ScreenshotPluginTest
} }
@Test @Test
public void testAttack() public void testAttackLevel70()
{ {
Widget widget = mock(Widget.class); Widget widget = mock(Widget.class);
when(widget.getId()).thenReturn(PACK(LEVEL_UP_GROUP_ID, 0)); when(widget.getId()).thenReturn(PACK(LEVEL_UP_GROUP_ID, 0));
@@ -190,7 +190,7 @@ public class ScreenshotPluginTest
} }
@Test @Test
public void testHunter() public void testHunterLevel2()
{ {
Widget widget = mock(Widget.class); Widget widget = mock(Widget.class);
when(widget.getId()).thenReturn(PACK(DIALOG_SPRITE_GROUP_ID, 0)); when(widget.getId()).thenReturn(PACK(DIALOG_SPRITE_GROUP_ID, 0));