From deb70796da2a5326c0058f2bef813393db84d3e3 Mon Sep 17 00:00:00 2001 From: SoyChai Date: Sun, 8 Apr 2018 12:04:40 +1000 Subject: [PATCH] screenshot: Define more accurate method names and access levels --- .../plugins/screenshot/ScreenshotPlugin.java | 2 +- .../screenshot/ScreenshotPluginTest.java | 22 +++++++++---------- 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/runelite-client/src/main/java/net/runelite/client/plugins/screenshot/ScreenshotPlugin.java b/runelite-client/src/main/java/net/runelite/client/plugins/screenshot/ScreenshotPlugin.java index 60fd0a3c53..1ac8592a0d 100644 --- a/runelite-client/src/main/java/net/runelite/client/plugins/screenshot/ScreenshotPlugin.java +++ b/runelite-client/src/main/java/net/runelite/client/plugins/screenshot/ScreenshotPlugin.java @@ -342,7 +342,7 @@ public class ScreenshotPlugin extends Plugin * with the format "Your Skill (level is/are) now 99." * @return Shortened string in the format "Skill(99)" */ - public String parseLevelUpWidget(WidgetInfo levelUpLevel) + String parseLevelUpWidget(WidgetInfo levelUpLevel) { Widget levelChild = client.getWidget(levelUpLevel); if (levelChild == null) diff --git a/runelite-client/src/test/java/net/runelite/client/plugins/screenshot/ScreenshotPluginTest.java b/runelite-client/src/test/java/net/runelite/client/plugins/screenshot/ScreenshotPluginTest.java index ef4363a77d..9aae5fc48e 100644 --- a/runelite-client/src/test/java/net/runelite/client/plugins/screenshot/ScreenshotPluginTest.java +++ b/runelite-client/src/test/java/net/runelite/client/plugins/screenshot/ScreenshotPluginTest.java @@ -64,14 +64,14 @@ public class ScreenshotPluginTest @Mock @Bind - Client client; + private Client client; @Inject - ScreenshotPlugin screenshotPlugin; + private ScreenshotPlugin screenshotPlugin; @Mock @Bind - ScreenshotConfig screenshotConfig; + private ScreenshotConfig screenshotConfig; @Mock @Bind @@ -83,7 +83,7 @@ public class ScreenshotPluginTest @Mock @Bind - OverlayRenderer overlayRenderer; + private OverlayRenderer overlayRenderer; @Mock @Bind @@ -102,7 +102,7 @@ public class ScreenshotPluginTest } @Test - public void testcluescroll() + public void testClueScroll() { ChatMessage chatMessageEvent = new ChatMessage(SERVER, "Seth", CLUE_SCROLL, null); screenshotPlugin.onChatMessage(chatMessageEvent); @@ -112,7 +112,7 @@ public class ScreenshotPluginTest } @Test - public void testbarrowschest() + public void testBarrowsChest() { ChatMessage chatMessageEvent = new ChatMessage(SERVER, "Seth", BARROWS_CHEST, null); screenshotPlugin.onChatMessage(chatMessageEvent); @@ -121,7 +121,7 @@ public class ScreenshotPluginTest } @Test - public void testraidschest() + public void testRaidsChest() { ChatMessage chatMessageEvent = new ChatMessage(SERVER, "Seth", RAIDS_CHEST, null); screenshotPlugin.onChatMessage(chatMessageEvent); @@ -130,7 +130,7 @@ public class ScreenshotPluginTest } @Test - public void testHitpoints() + public void testHitpointsLevel99() { Widget widget = mock(Widget.class); when(widget.getId()).thenReturn(PACK(LEVEL_UP_GROUP_ID, 0)); @@ -150,7 +150,7 @@ public class ScreenshotPluginTest } @Test - public void testFiremaking() + public void testFiremakingLevel9() { Widget widget = mock(Widget.class); when(widget.getId()).thenReturn(PACK(LEVEL_UP_GROUP_ID, 0)); @@ -170,7 +170,7 @@ public class ScreenshotPluginTest } @Test - public void testAttack() + public void testAttackLevel70() { Widget widget = mock(Widget.class); when(widget.getId()).thenReturn(PACK(LEVEL_UP_GROUP_ID, 0)); @@ -190,7 +190,7 @@ public class ScreenshotPluginTest } @Test - public void testHunter() + public void testHunterLevel2() { Widget widget = mock(Widget.class); when(widget.getId()).thenReturn(PACK(DIALOG_SPRITE_GROUP_ID, 0));