Log whole HTTP response instead of just message (#8126)
Response message is usually either empty or not useful. Closes #8042
This commit is contained in:
committed by
Tomas Slusny
parent
be98ced0f5
commit
84009901cb
@@ -55,7 +55,7 @@ public class FeedClient
|
|||||||
{
|
{
|
||||||
if (!response.isSuccessful())
|
if (!response.isSuccessful())
|
||||||
{
|
{
|
||||||
logger.debug("Error looking up feed: {}", response.message());
|
logger.debug("Error looking up feed: {}", response);
|
||||||
return null;
|
return null;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -106,7 +106,7 @@ public class HiscoreClient
|
|||||||
case 404:
|
case 404:
|
||||||
return null;
|
return null;
|
||||||
default:
|
default:
|
||||||
throw new IOException("Error retrieving data from Jagex Hiscores: " + okresponse.message());
|
throw new IOException("Error retrieving data from Jagex Hiscores: " + okresponse);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -63,7 +63,7 @@ public class ItemClient
|
|||||||
{
|
{
|
||||||
if (!response.isSuccessful())
|
if (!response.isSuccessful())
|
||||||
{
|
{
|
||||||
logger.debug("Error looking up item {}: {}", itemId, response.message());
|
logger.debug("Error looking up item {}: {}", itemId, response);
|
||||||
return null;
|
return null;
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -99,7 +99,7 @@ public class ItemClient
|
|||||||
{
|
{
|
||||||
if (!response.isSuccessful())
|
if (!response.isSuccessful())
|
||||||
{
|
{
|
||||||
logger.debug("Error looking up items {}: {}", Arrays.toString(itemIds), response.message());
|
logger.debug("Error looking up items {}: {}", Arrays.toString(itemIds), response);
|
||||||
return null;
|
return null;
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -130,7 +130,7 @@ public class ItemClient
|
|||||||
{
|
{
|
||||||
if (!response.isSuccessful())
|
if (!response.isSuccessful())
|
||||||
{
|
{
|
||||||
logger.debug("Error grabbing icon {}: {}", itemId, response.message());
|
logger.debug("Error grabbing icon {}: {}", itemId, response);
|
||||||
return null;
|
return null;
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -160,7 +160,7 @@ public class ItemClient
|
|||||||
{
|
{
|
||||||
if (!response.isSuccessful())
|
if (!response.isSuccessful())
|
||||||
{
|
{
|
||||||
logger.debug("Error looking up item {}: {}", itemName, response.message());
|
logger.debug("Error looking up item {}: {}", itemName, response);
|
||||||
return null;
|
return null;
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -191,7 +191,7 @@ public class ItemClient
|
|||||||
{
|
{
|
||||||
if (!response.isSuccessful())
|
if (!response.isSuccessful())
|
||||||
{
|
{
|
||||||
logger.warn("Error looking up prices: {}", response.message());
|
logger.warn("Error looking up prices: {}", response);
|
||||||
return null;
|
return null;
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -223,7 +223,7 @@ public class ItemClient
|
|||||||
{
|
{
|
||||||
if (!response.isSuccessful())
|
if (!response.isSuccessful())
|
||||||
{
|
{
|
||||||
logger.warn("Error looking up item stats: {}", response.message());
|
logger.warn("Error looking up item stats: {}", response);
|
||||||
return null;
|
return null;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -97,7 +97,7 @@ public class LootTrackerClient
|
|||||||
{
|
{
|
||||||
if (!response.isSuccessful())
|
if (!response.isSuccessful())
|
||||||
{
|
{
|
||||||
log.debug("Error looking up loot: {}", response.message());
|
log.debug("Error looking up loot: {}", response);
|
||||||
return null;
|
return null;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -55,7 +55,7 @@ public class OSBGrandExchangeClient
|
|||||||
{
|
{
|
||||||
if (!response.isSuccessful())
|
if (!response.isSuccessful())
|
||||||
{
|
{
|
||||||
throw new IOException("Error looking up item id: " + response.message());
|
throw new IOException("Error looking up item id: " + response);
|
||||||
}
|
}
|
||||||
|
|
||||||
final InputStream in = response.body().byteStream();
|
final InputStream in = response.body().byteStream();
|
||||||
|
|||||||
@@ -57,7 +57,7 @@ public class WorldClient
|
|||||||
{
|
{
|
||||||
if (!response.isSuccessful())
|
if (!response.isSuccessful())
|
||||||
{
|
{
|
||||||
logger.debug("Error looking up worlds: {}", response.message());
|
logger.debug("Error looking up worlds: {}", response);
|
||||||
return null;
|
return null;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -63,7 +63,7 @@ public class BlogService
|
|||||||
{
|
{
|
||||||
if (!response.isSuccessful())
|
if (!response.isSuccessful())
|
||||||
{
|
{
|
||||||
throw new IOException("Error getting blog posts: " + response.message());
|
throw new IOException("Error getting blog posts: " + response);
|
||||||
}
|
}
|
||||||
|
|
||||||
try
|
try
|
||||||
|
|||||||
@@ -63,7 +63,7 @@ public class OSRSNewsService
|
|||||||
{
|
{
|
||||||
if (!response.isSuccessful())
|
if (!response.isSuccessful())
|
||||||
{
|
{
|
||||||
throw new IOException("Error getting OSRS news: " + response.message());
|
throw new IOException("Error getting OSRS news: " + response);
|
||||||
}
|
}
|
||||||
|
|
||||||
try
|
try
|
||||||
|
|||||||
@@ -103,9 +103,9 @@ public class TwitterService
|
|||||||
{
|
{
|
||||||
return getTweets(true);
|
return getTweets(true);
|
||||||
}
|
}
|
||||||
throw new InternalServerErrorException("Could not auth to Twitter after trying once: " + response.message());
|
throw new InternalServerErrorException("Could not auth to Twitter after trying once: " + response);
|
||||||
default:
|
default:
|
||||||
throw new IOException("Error getting Twitter list: " + response.message());
|
throw new IOException("Error getting Twitter list: " + response);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -146,7 +146,7 @@ public class TwitterService
|
|||||||
{
|
{
|
||||||
if (!response.isSuccessful())
|
if (!response.isSuccessful())
|
||||||
{
|
{
|
||||||
throw new IOException("Error authing to Twitter: " + response.message());
|
throw new IOException("Error authing to Twitter: " + response);
|
||||||
}
|
}
|
||||||
|
|
||||||
InputStream in = response.body().byteStream();
|
InputStream in = response.body().byteStream();
|
||||||
|
|||||||
@@ -377,7 +377,7 @@ public class ItemService
|
|||||||
{
|
{
|
||||||
if (!response.isSuccessful())
|
if (!response.isSuccessful())
|
||||||
{
|
{
|
||||||
throw new IOException("Unsuccessful http response: " + response.message());
|
throw new IOException("Unsuccessful http response: " + response);
|
||||||
}
|
}
|
||||||
|
|
||||||
InputStream in = response.body().byteStream();
|
InputStream in = response.body().byteStream();
|
||||||
@@ -401,7 +401,7 @@ public class ItemService
|
|||||||
{
|
{
|
||||||
if (!response.isSuccessful())
|
if (!response.isSuccessful())
|
||||||
{
|
{
|
||||||
throw new IOException("Unsuccessful http response: " + response.message());
|
throw new IOException("Unsuccessful http response: " + response);
|
||||||
}
|
}
|
||||||
|
|
||||||
return response.body().bytes();
|
return response.body().bytes();
|
||||||
|
|||||||
Reference in New Issue
Block a user