From 84009901cba1ac9856eb43a5ebd76879053632c9 Mon Sep 17 00:00:00 2001 From: Nathaniel Ngo Date: Mon, 18 Mar 2019 20:58:46 -0400 Subject: [PATCH] Log whole HTTP response instead of just message (#8126) Response message is usually either empty or not useful. Closes #8042 --- .../java/net/runelite/http/api/feed/FeedClient.java | 2 +- .../net/runelite/http/api/hiscore/HiscoreClient.java | 2 +- .../java/net/runelite/http/api/item/ItemClient.java | 12 ++++++------ .../http/api/loottracker/LootTrackerClient.java | 2 +- .../http/api/osbuddy/OSBGrandExchangeClient.java | 2 +- .../net/runelite/http/api/worlds/WorldClient.java | 2 +- .../runelite/http/service/feed/blog/BlogService.java | 2 +- .../http/service/feed/osrsnews/OSRSNewsService.java | 2 +- .../http/service/feed/twitter/TwitterService.java | 6 +++--- .../net/runelite/http/service/item/ItemService.java | 4 ++-- 10 files changed, 18 insertions(+), 18 deletions(-) diff --git a/http-api/src/main/java/net/runelite/http/api/feed/FeedClient.java b/http-api/src/main/java/net/runelite/http/api/feed/FeedClient.java index ea1fe18fd6..6b05ad20ba 100644 --- a/http-api/src/main/java/net/runelite/http/api/feed/FeedClient.java +++ b/http-api/src/main/java/net/runelite/http/api/feed/FeedClient.java @@ -55,7 +55,7 @@ public class FeedClient { if (!response.isSuccessful()) { - logger.debug("Error looking up feed: {}", response.message()); + logger.debug("Error looking up feed: {}", response); return null; } diff --git a/http-api/src/main/java/net/runelite/http/api/hiscore/HiscoreClient.java b/http-api/src/main/java/net/runelite/http/api/hiscore/HiscoreClient.java index 3f3f968d83..a725089de4 100644 --- a/http-api/src/main/java/net/runelite/http/api/hiscore/HiscoreClient.java +++ b/http-api/src/main/java/net/runelite/http/api/hiscore/HiscoreClient.java @@ -106,7 +106,7 @@ public class HiscoreClient case 404: return null; default: - throw new IOException("Error retrieving data from Jagex Hiscores: " + okresponse.message()); + throw new IOException("Error retrieving data from Jagex Hiscores: " + okresponse); } } diff --git a/http-api/src/main/java/net/runelite/http/api/item/ItemClient.java b/http-api/src/main/java/net/runelite/http/api/item/ItemClient.java index 2aa8b5c678..17784dd67b 100644 --- a/http-api/src/main/java/net/runelite/http/api/item/ItemClient.java +++ b/http-api/src/main/java/net/runelite/http/api/item/ItemClient.java @@ -63,7 +63,7 @@ public class ItemClient { if (!response.isSuccessful()) { - logger.debug("Error looking up item {}: {}", itemId, response.message()); + logger.debug("Error looking up item {}: {}", itemId, response); return null; } @@ -99,7 +99,7 @@ public class ItemClient { if (!response.isSuccessful()) { - logger.debug("Error looking up items {}: {}", Arrays.toString(itemIds), response.message()); + logger.debug("Error looking up items {}: {}", Arrays.toString(itemIds), response); return null; } @@ -130,7 +130,7 @@ public class ItemClient { if (!response.isSuccessful()) { - logger.debug("Error grabbing icon {}: {}", itemId, response.message()); + logger.debug("Error grabbing icon {}: {}", itemId, response); return null; } @@ -160,7 +160,7 @@ public class ItemClient { if (!response.isSuccessful()) { - logger.debug("Error looking up item {}: {}", itemName, response.message()); + logger.debug("Error looking up item {}: {}", itemName, response); return null; } @@ -191,7 +191,7 @@ public class ItemClient { if (!response.isSuccessful()) { - logger.warn("Error looking up prices: {}", response.message()); + logger.warn("Error looking up prices: {}", response); return null; } @@ -223,7 +223,7 @@ public class ItemClient { if (!response.isSuccessful()) { - logger.warn("Error looking up item stats: {}", response.message()); + logger.warn("Error looking up item stats: {}", response); return null; } diff --git a/http-api/src/main/java/net/runelite/http/api/loottracker/LootTrackerClient.java b/http-api/src/main/java/net/runelite/http/api/loottracker/LootTrackerClient.java index 0d9ec845b3..d250620905 100644 --- a/http-api/src/main/java/net/runelite/http/api/loottracker/LootTrackerClient.java +++ b/http-api/src/main/java/net/runelite/http/api/loottracker/LootTrackerClient.java @@ -97,7 +97,7 @@ public class LootTrackerClient { if (!response.isSuccessful()) { - log.debug("Error looking up loot: {}", response.message()); + log.debug("Error looking up loot: {}", response); return null; } diff --git a/http-api/src/main/java/net/runelite/http/api/osbuddy/OSBGrandExchangeClient.java b/http-api/src/main/java/net/runelite/http/api/osbuddy/OSBGrandExchangeClient.java index ffdfad2035..c01337fdc0 100644 --- a/http-api/src/main/java/net/runelite/http/api/osbuddy/OSBGrandExchangeClient.java +++ b/http-api/src/main/java/net/runelite/http/api/osbuddy/OSBGrandExchangeClient.java @@ -55,7 +55,7 @@ public class OSBGrandExchangeClient { if (!response.isSuccessful()) { - throw new IOException("Error looking up item id: " + response.message()); + throw new IOException("Error looking up item id: " + response); } final InputStream in = response.body().byteStream(); diff --git a/http-api/src/main/java/net/runelite/http/api/worlds/WorldClient.java b/http-api/src/main/java/net/runelite/http/api/worlds/WorldClient.java index 1ac8195cce..668e088404 100644 --- a/http-api/src/main/java/net/runelite/http/api/worlds/WorldClient.java +++ b/http-api/src/main/java/net/runelite/http/api/worlds/WorldClient.java @@ -57,7 +57,7 @@ public class WorldClient { if (!response.isSuccessful()) { - logger.debug("Error looking up worlds: {}", response.message()); + logger.debug("Error looking up worlds: {}", response); return null; } diff --git a/http-service/src/main/java/net/runelite/http/service/feed/blog/BlogService.java b/http-service/src/main/java/net/runelite/http/service/feed/blog/BlogService.java index 6b94b609d5..9da6cc171b 100644 --- a/http-service/src/main/java/net/runelite/http/service/feed/blog/BlogService.java +++ b/http-service/src/main/java/net/runelite/http/service/feed/blog/BlogService.java @@ -63,7 +63,7 @@ public class BlogService { if (!response.isSuccessful()) { - throw new IOException("Error getting blog posts: " + response.message()); + throw new IOException("Error getting blog posts: " + response); } try diff --git a/http-service/src/main/java/net/runelite/http/service/feed/osrsnews/OSRSNewsService.java b/http-service/src/main/java/net/runelite/http/service/feed/osrsnews/OSRSNewsService.java index 6936109343..0ae08bc85c 100644 --- a/http-service/src/main/java/net/runelite/http/service/feed/osrsnews/OSRSNewsService.java +++ b/http-service/src/main/java/net/runelite/http/service/feed/osrsnews/OSRSNewsService.java @@ -63,7 +63,7 @@ public class OSRSNewsService { if (!response.isSuccessful()) { - throw new IOException("Error getting OSRS news: " + response.message()); + throw new IOException("Error getting OSRS news: " + response); } try diff --git a/http-service/src/main/java/net/runelite/http/service/feed/twitter/TwitterService.java b/http-service/src/main/java/net/runelite/http/service/feed/twitter/TwitterService.java index 3ac032dc63..9bb9dc8595 100644 --- a/http-service/src/main/java/net/runelite/http/service/feed/twitter/TwitterService.java +++ b/http-service/src/main/java/net/runelite/http/service/feed/twitter/TwitterService.java @@ -103,9 +103,9 @@ public class TwitterService { return getTweets(true); } - throw new InternalServerErrorException("Could not auth to Twitter after trying once: " + response.message()); + throw new InternalServerErrorException("Could not auth to Twitter after trying once: " + response); default: - throw new IOException("Error getting Twitter list: " + response.message()); + throw new IOException("Error getting Twitter list: " + response); } } @@ -146,7 +146,7 @@ public class TwitterService { if (!response.isSuccessful()) { - throw new IOException("Error authing to Twitter: " + response.message()); + throw new IOException("Error authing to Twitter: " + response); } InputStream in = response.body().byteStream(); diff --git a/http-service/src/main/java/net/runelite/http/service/item/ItemService.java b/http-service/src/main/java/net/runelite/http/service/item/ItemService.java index 32569b0517..72a0fe85aa 100644 --- a/http-service/src/main/java/net/runelite/http/service/item/ItemService.java +++ b/http-service/src/main/java/net/runelite/http/service/item/ItemService.java @@ -377,7 +377,7 @@ public class ItemService { if (!response.isSuccessful()) { - throw new IOException("Unsuccessful http response: " + response.message()); + throw new IOException("Unsuccessful http response: " + response); } InputStream in = response.body().byteStream(); @@ -401,7 +401,7 @@ public class ItemService { if (!response.isSuccessful()) { - throw new IOException("Unsuccessful http response: " + response.message()); + throw new IOException("Unsuccessful http response: " + response); } return response.body().bytes();