ra/runelite
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

attack styles: Attach spec bar redraw listener to weapon text

Browse Source 
This fixes a bug where the special attack bar would not be redrawn if
the combat tab was opened with any weapon equipped which did not have a
special attack bar. The weapon text widget is used because it is always
rendered with the combat tab widgets, and does not already have any kind
of listeners attached.

Fixes runelite/runelite#8946
This commit is contained in:
Jordan Atwood
2019-05-28 19:06:09 -07:00
committed by Adam
parent 5ec52d3591
commit 81050f264a
3 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
runelite-api/src/main/java/net/runelite/api/widgets/WidgetID.java
View File

@@ -533,7 +533,6 @@ public class WidgetID
static final int SPELL_ICON = 27;
static final int SPELL_TEXT = 28;
static final int AUTO_RETALIATE = 29;
static final int SPEC_BAR = 34;
}
static class VolcanicMine

1
runelite-api/src/main/java/net/runelite/api/widgets/WidgetInfo.java
View File

@@ -313,7 +313,6 @@ public enum WidgetInfo
COMBAT_SPELL_ICON(WidgetID.COMBAT_GROUP_ID, WidgetID.Combat.SPELL_ICON),
COMBAT_SPELL_TEXT(WidgetID.COMBAT_GROUP_ID, WidgetID.Combat.SPELL_TEXT),
COMBAT_AUTO_RETALIATE(WidgetID.COMBAT_GROUP_ID, WidgetID.Combat.AUTO_RETALIATE),
COMBAT_SPEC_BAR(WidgetID.COMBAT_GROUP_ID, WidgetID.Combat.SPEC_BAR), // Used by CombatInterfaceSP.rs2asm
DIALOG_OPTION(WidgetID.DIALOG_OPTION_GROUP_ID, 0),

4
runelite-client/src/main/scripts/CombatInterfaceSP.rs2asm
View File

@@ -3,10 +3,10 @@
.string_stack_count 0
.int_var_count 1
.string_var_count 0
; Attach specbar redraw listeners to special attack bar instead of to
; Attach specbar redraw listeners to the weapon name text instead of to
; auto retaliate text (which is var0). Test by enabling "Hide auto retaliate"
; and using a spec.
iconst 38862882 ; 593.34 - spec bar
iconst 38862849 ; 593.1 - weapon name widget
istore 0 ; overwrite script parameter which is the autoretail text
iload 0
invoke 187