gpu: run glslangValidator on shaders during tests

pom.xml

@@ -42,6 +42,7 @@
 
 		<maven.javadoc.skip>true</maven.javadoc.skip>
 		<checkstyle.skip>true</checkstyle.skip>
+		<glslang.path></glslang.path>
 
 		<rs.version>188</rs.version>
 	</properties>
@@ -171,6 +172,9 @@
 				<configuration>
 					<enableAssertions>true</enableAssertions>
 					<argLine>-Xmx512m</argLine>
+					<systemProperties>
+						<glslang.path>${glslang.path}</glslang.path>
+					</systemProperties>
 				</configuration>
 			</plugin>
 			<plugin>

runelite-client/src/test/java/net/runelite/client/plugins/gpu/ShaderTest.java

@@ -0,0 +1,130 @@
+/*
+ * Copyright (c) 2020 Abex
+ * All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are met:
+ *
+ * 1. Redistributions of source code must retain the above copyright notice, this
+ *    list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright notice,
+ *    this list of conditions and the following disclaimer in the documentation
+ *    and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND
+ * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
+ * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+ * DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR
+ * ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
+ * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
+ * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
+ * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
+ * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+package net.runelite.client.plugins.gpu;
+
+import com.jogamp.opengl.GL4;
+import java.io.File;
+import java.nio.charset.StandardCharsets;
+import java.nio.file.Files;
+import java.util.ArrayList;
+import java.util.List;
+import joptsimple.internal.Strings;
+import lombok.extern.slf4j.Slf4j;
+import net.runelite.client.plugins.gpu.template.Template;
+import org.junit.Assert;
+import org.junit.Assume;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.rules.TemporaryFolder;
+
+@Slf4j
+public class ShaderTest
+{
+	@Rule
+	public TemporaryFolder temp = new TemporaryFolder();
+
+	@Test
+	public void testShaders() throws Exception
+	{
+		String verifier = System.getProperty("glslang.path");
+		Assume.assumeFalse("glslang.path is not set", Strings.isNullOrEmpty(verifier));
+
+		Template[] templates = {
+			new Template()
+				.addInclude(GpuPlugin.class)
+				.add(key ->
+			{
+				if ("version_header".equals(key))
+				{
+					return GpuPlugin.WINDOWS_VERSION_HEADER;
+				}
+				return null;
+			}),
+		};
+
+		Shader[] shaders = {
+			GpuPlugin.PROGRAM,
+			GpuPlugin.COMPUTE_PROGRAM,
+			GpuPlugin.SMALL_COMPUTE_PROGRAM,
+			GpuPlugin.UNORDERED_COMPUTE_PROGRAM,
+			GpuPlugin.UI_PROGRAM,
+		};
+
+		for (Template t : templates)
+		{
+			for (Shader s : shaders)
+			{
+				verify(t, s);
+			}
+		}
+	}
+
+	private void verify(Template template, Shader shader) throws Exception
+	{
+		File folder = temp.newFolder();
+		List<String> args = new ArrayList<>();
+		args.add(System.getProperty("glslang.path"));
+		args.add("-l");
+		for (Shader.Unit u : shader.units)
+		{
+			String contents = template.load(u.getFilename());
+			String ext;
+			switch (u.getType())
+			{
+				case GL4.GL_VERTEX_SHADER:
+					ext = "vert";
+					break;
+				case GL4.GL_TESS_CONTROL_SHADER:
+					ext = "tesc";
+					break;
+				case GL4.GL_TESS_EVALUATION_SHADER:
+					ext = "tese";
+					break;
+				case GL4.GL_GEOMETRY_SHADER:
+					ext = "geom";
+					break;
+				case GL4.GL_FRAGMENT_SHADER:
+					ext = "frag";
+					break;
+				case GL4.GL_COMPUTE_SHADER:
+					ext = "comp";
+					break;
+				default:
+					throw new IllegalArgumentException(u.getType() + "");
+			}
+			File file = new File(folder, u.getFilename() + "." + ext);
+			Files.write(file.toPath(), contents.getBytes(StandardCharsets.UTF_8));
+			args.add(file.getAbsolutePath());
+		}
+
+		ProcessBuilder pb = new ProcessBuilder(args.toArray(new String[0]));
+		pb.inheritIO();
+		Process proc = pb.start();
+		if (proc.waitFor() != 0)
+		{
+			Assert.fail();
+		}
+	}
+}

travis/build.sh

@@ -1,3 +1,9 @@
 #!/bin/bash
 
-mvn clean install --settings travis/settings.xml
+set -e -x
+
+wget -O/tmp/glslang.zip 'https://github.com/KhronosGroup/glslang/releases/download/8.13.3559/glslang-master-linux-Release.zip'
+echo '9adcfdef5b52275e61068aafbb62747936c6c18ab6dc32a6ef707cfc7b0df423  /tmp/glslang.zip' | sha256sum -c
+unzip -q /tmp/glslang.zip -d /tmp/glslang
+
+mvn clean install --settings travis/settings.xml -Dglslang.path=/tmp/glslang/bin/glslangValidator