ra/runelite
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

ground markers: Fix marking non-marked tiles

Browse Source 
This fixes the bug introduced in runelite/runelite#5890 where attempting
to mark a non-marked tile while having the "Remember color per tile"
config disabled would prevent new tiles from being marked. Instead, it
properly ensures that unmarking tiles with that config disabled will not
re-mark it with an updated color, causing a second unmark to be needed.
This commit is contained in:
Jordan Atwood
2019-03-02 09:27:54 -08:00
parent 72b3e4560d
commit 7e02694652
1 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
runelite-client/src/main/java/net/runelite/client/plugins/groundmarkers/GroundMarkerPlugin.java
View File

@@ -314,11 +314,10 @@ public class GroundMarkerPlugin extends Plugin
}
else
{
// Remove any points on the same tile but are of a different color
points.removeIf(p -> p.sameTile(point));
// Add point back only if we are remembering tile colors, otherwise simply remove it
if (config.rememberTileColors())
// Remove any points on the same tile but are of a different color.
// Add a new point if no tile was removed, or if remembering tile colors is enabled, which means the marked
// tile was previously of a different color than the new tile marking.
if (!points.removeIf(p -> p.sameTile(point)) || config.rememberTileColors())
{
points.add(point);
}