ra/runelite
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

banktags: remove setBankScroll event

Browse Source 
This hasn't worked in awhile since it was assining the scroll value to the
wrong variable. Now we are computing the scroll in onScriptPreFixed for
[proc,bankmain_finishbuilding], so it is no longer necessary here.
This commit is contained in:
Adam
2021-11-10 17:37:56 -05:00
parent c8ec004b7a
commit 70d916af52
2 changed files with 5 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
runelite-client/src/main/java/net/runelite/client/plugins/banktags/tabs/TabInterface.java
View File

@@ -573,7 +573,7 @@ public class TabInterface
switch (eventName) switch (eventName)
{ {
case "setBankScroll": case "skipBankLayout":
if (!isTabMenuActive()) if (!isTabMenuActive())
{ {
setTabMenuVisible(false); setTabMenuVisible(false);
@@ -582,11 +582,8 @@ public class TabInterface
setTabMenuVisible(true); setTabMenuVisible(true);
// scroll height
intStack[intStackSize - 3] = (((tabManager.getTabs().size() - 1) / BANK_ITEMS_PER_ROW) + 1) * (BANK_ITEM_HEIGHT + BANK_ITEM_Y_PADDING);
// skip normal bank layout // skip normal bank layout
intStack[intStackSize - 2] = 1; intStack[intStackSize - 1] = 1;
break; break;
case "beforeBankLayout": case "beforeBankLayout":
setTabMenuVisible(false); setTabMenuVisible(false);

8
runelite-client/src/main/scripts/BankSearchLayout.rs2asm
View File

@@ -7,8 +7,8 @@
; Fired before the bank starts its layout ; Fired before the bank starts its layout
; Used by the TabInterface to hide fake bank items for tag tabs ; Used by the TabInterface to hide fake bank items for tag tabs
; ;
; callback "setBankScroll" ; callback "skipBankLayout"
; Fired before bank is calculated ; Fired before bank is built
; Used by the TabInterface to show fake bank items for tag tabs ; Used by the TabInterface to show fake bank items for tag tabs
sconst "beforeBankLayout" sconst "beforeBankLayout"
runelite_callback runelite_callback
@@ -403,13 +403,11 @@ LABEL348:
sub sub
istore 30 istore 30
LABEL352: LABEL352:
iconst 0 ; Scroll height variable
iconst 0 ; Compare variable iconst 0 ; Compare variable
iconst 0 ; iconst 0 ;
sconst "setBankScroll" ; Show fake bank items for tag tabs sconst "skipBankLayout" ; Show fake bank items for tag tabs
runelite_callback ; If tag tab menu search isn't active runelite_callback ; If tag tab menu search isn't active
if_icmpeq CONTINUE_SEARCH ; continue to normal bank search if_icmpeq CONTINUE_SEARCH ; continue to normal bank search
istore 27 ; Load scroll height into variable
jump GetTabRange ; Skip normal bank layout jump GetTabRange ; Skip normal bank layout
CONTINUE_SEARCH: CONTINUE_SEARCH:
iload 31 iload 31