banktags: remove setBankScroll event

This hasn't worked in awhile since it was assining the scroll value to the
wrong variable. Now we are computing the scroll in onScriptPreFixed for
[proc,bankmain_finishbuilding], so it is no longer necessary here.

runelite-client/src/main/java/net/runelite/client/plugins/banktags/tabs/TabInterface.java

@@ -573,7 +573,7 @@ public class TabInterface
 
 		switch (eventName)
 		{
-			case "setBankScroll":
+			case "skipBankLayout":
 				if (!isTabMenuActive())
 				{
 					setTabMenuVisible(false);
@@ -582,11 +582,8 @@ public class TabInterface
 
 				setTabMenuVisible(true);
 
-				// scroll height
-				intStack[intStackSize - 3] = (((tabManager.getTabs().size() - 1) / BANK_ITEMS_PER_ROW) + 1) * (BANK_ITEM_HEIGHT + BANK_ITEM_Y_PADDING);
-
 				// skip normal bank layout
-				intStack[intStackSize - 2] = 1;
+				intStack[intStackSize - 1] = 1;
 				break;
 			case "beforeBankLayout":
 				setTabMenuVisible(false);

runelite-client/src/main/scripts/BankSearchLayout.rs2asm

@@ -7,8 +7,8 @@
 ;   Fired before the bank starts its layout
 ;	Used by the TabInterface to hide fake bank items for tag tabs
 ;
-; callback "setBankScroll"
-;	Fired before bank is calculated
+; callback "skipBankLayout"
+;	Fired before bank is built
 ;   Used by the TabInterface to show fake bank items for tag tabs
    sconst                 "beforeBankLayout"
    runelite_callback     
@@ -403,13 +403,11 @@ LABEL348:
    sub                   
    istore                 30
 LABEL352:
-   iconst                 0               	; Scroll height variable
    iconst                 0               	; Compare variable
    iconst                 0               	;
-   sconst                 "setBankScroll"   ; Show fake bank items for tag tabs
+   sconst                 "skipBankLayout"   ; Show fake bank items for tag tabs
    runelite_callback     ; If tag tab menu search isn't active
    if_icmpeq              CONTINUE_SEARCH 	; continue to normal bank search
-   istore                 27                ; Load scroll height into variable
    jump                   GetTabRange     	; Skip normal bank layout
 CONTINUE_SEARCH:
    iload                  31