Fixes based on review

- Removed positions from config
- Renamed config values to a better name
- Fixed descriptions of config values to make more sense
This commit is contained in:
ErmalSh
2019-01-20 16:40:41 -05:00
parent fcd47e012a
commit 2d5b117060

View File

@@ -35,8 +35,7 @@ public interface CannonConfig extends Config
@ConfigItem( @ConfigItem(
keyName = "showEmptyCannonNotification", keyName = "showEmptyCannonNotification",
name = "Empty cannon notification", name = "Empty cannon notification",
description = "Configures whether to notify you that the cannon is empty", description = "Configures whether to notify you that the cannon is empty"
position = 1
) )
default boolean showEmptyCannonNotification() default boolean showEmptyCannonNotification()
{ {
@@ -46,8 +45,7 @@ public interface CannonConfig extends Config
@ConfigItem( @ConfigItem(
keyName = "showInfobox", keyName = "showInfobox",
name = "Show Cannonball infobox", name = "Show Cannonball infobox",
description = "Configures whether to show the cannonballs in an infobox", description = "Configures whether to show the cannonballs in an infobox"
position = 2
) )
default boolean showInfobox() default boolean showInfobox()
{ {
@@ -57,8 +55,7 @@ public interface CannonConfig extends Config
@ConfigItem( @ConfigItem(
keyName = "showDoubleHitSpot", keyName = "showDoubleHitSpot",
name = "Show double hit spots", name = "Show double hit spots",
description = "Configures whether to show the NPC double hit spot", description = "Configures whether to show the NPC double hit spot"
position = 3
) )
default boolean showDoubleHitSpot() default boolean showDoubleHitSpot()
{ {
@@ -68,8 +65,7 @@ public interface CannonConfig extends Config
@ConfigItem( @ConfigItem(
keyName = "highlightDoubleHitColor", keyName = "highlightDoubleHitColor",
name = "Color of double hit spots", name = "Color of double hit spots",
description = "Configures the highlight color of double hit spots", description = "Configures the highlight color of double hit spots"
position = 4
) )
default Color highlightDoubleHitColor() default Color highlightDoubleHitColor()
{ {
@@ -79,8 +75,7 @@ public interface CannonConfig extends Config
@ConfigItem( @ConfigItem(
keyName = "showCannonSpots", keyName = "showCannonSpots",
name = "Show common cannon spots", name = "Show common cannon spots",
description = "Configures whether to show common cannon spots or not", description = "Configures whether to show common cannon spots or not"
position = 5
) )
default boolean showCannonSpots() default boolean showCannonSpots()
{ {
@@ -89,9 +84,8 @@ public interface CannonConfig extends Config
@ConfigItem( @ConfigItem(
keyName = "ammoAmount", keyName = "ammoAmount",
name = "Ammo left notification", name = "Ammo left",
description = "Configure to set the amount of ammo left to receive low ammo notification", description = "Configure to set the amount of ammo left to receive ammo left notification"
position = 6
) )
default int ammoAmount() default int ammoAmount()
{ {
@@ -100,9 +94,8 @@ public interface CannonConfig extends Config
@ConfigItem( @ConfigItem(
keyName = "notifyAmmoLeft", keyName = "notifyAmmoLeft",
name = "Show amount left notification", name = "Ammo left notification",
description = "Sends a notification when cannon ammo is under the specified amount", description = "Sends a notification when cannon ammo is under the specified amount"
position = 7
) )
default boolean notifyAmmoLeft() default boolean notifyAmmoLeft()
{ {