From 2d5b117060c5df5f90e8ea39c4b4462c56a2bf03 Mon Sep 17 00:00:00 2001 From: ErmalSh Date: Sun, 20 Jan 2019 16:40:41 -0500 Subject: [PATCH] Fixes based on review - Removed positions from config - Renamed config values to a better name - Fixed descriptions of config values to make more sense --- .../client/plugins/cannon/CannonConfig.java | 25 +++++++------------ 1 file changed, 9 insertions(+), 16 deletions(-) diff --git a/runelite-client/src/main/java/net/runelite/client/plugins/cannon/CannonConfig.java b/runelite-client/src/main/java/net/runelite/client/plugins/cannon/CannonConfig.java index b8016d02b2..a8fc176ad3 100644 --- a/runelite-client/src/main/java/net/runelite/client/plugins/cannon/CannonConfig.java +++ b/runelite-client/src/main/java/net/runelite/client/plugins/cannon/CannonConfig.java @@ -35,8 +35,7 @@ public interface CannonConfig extends Config @ConfigItem( keyName = "showEmptyCannonNotification", name = "Empty cannon notification", - description = "Configures whether to notify you that the cannon is empty", - position = 1 + description = "Configures whether to notify you that the cannon is empty" ) default boolean showEmptyCannonNotification() { @@ -46,8 +45,7 @@ public interface CannonConfig extends Config @ConfigItem( keyName = "showInfobox", name = "Show Cannonball infobox", - description = "Configures whether to show the cannonballs in an infobox", - position = 2 + description = "Configures whether to show the cannonballs in an infobox" ) default boolean showInfobox() { @@ -57,8 +55,7 @@ public interface CannonConfig extends Config @ConfigItem( keyName = "showDoubleHitSpot", name = "Show double hit spots", - description = "Configures whether to show the NPC double hit spot", - position = 3 + description = "Configures whether to show the NPC double hit spot" ) default boolean showDoubleHitSpot() { @@ -68,8 +65,7 @@ public interface CannonConfig extends Config @ConfigItem( keyName = "highlightDoubleHitColor", name = "Color of double hit spots", - description = "Configures the highlight color of double hit spots", - position = 4 + description = "Configures the highlight color of double hit spots" ) default Color highlightDoubleHitColor() { @@ -79,8 +75,7 @@ public interface CannonConfig extends Config @ConfigItem( keyName = "showCannonSpots", name = "Show common cannon spots", - description = "Configures whether to show common cannon spots or not", - position = 5 + description = "Configures whether to show common cannon spots or not" ) default boolean showCannonSpots() { @@ -89,9 +84,8 @@ public interface CannonConfig extends Config @ConfigItem( keyName = "ammoAmount", - name = "Ammo left notification", - description = "Configure to set the amount of ammo left to receive low ammo notification", - position = 6 + name = "Ammo left", + description = "Configure to set the amount of ammo left to receive ammo left notification" ) default int ammoAmount() { @@ -100,9 +94,8 @@ public interface CannonConfig extends Config @ConfigItem( keyName = "notifyAmmoLeft", - name = "Show amount left notification", - description = "Sends a notification when cannon ammo is under the specified amount", - position = 7 + name = "Ammo left notification", + description = "Sends a notification when cannon ammo is under the specified amount" ) default boolean notifyAmmoLeft() {