ra/runelite
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

remove static block initialization of superior list

Browse Source
This commit is contained in:
Davis Cook
2019-02-12 01:11:06 -05:00
parent 1cf7801045
commit 0baf0a8ecb
2 changed files with 34 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

54
runelite-client/src/main/java/net/runelite/client/plugins/slayer/SlayerPlugin.java
View File

@@ -127,35 +127,31 @@ public class SlayerPlugin extends Plugin
private static final int TASK_STRING_MAX_LENGTH = 50; private static final int TASK_STRING_MAX_LENGTH = 50;
// Superiors // Superiors
private static List<String> SUPERIOR_SLAYER_MONSTERS = Arrays.asList( @VisibleForTesting
"Crushing hand", static List<String> SUPERIOR_SLAYER_MONSTERS = Arrays.asList(
"Chasm crawler", "crushing hand",
"Screaming banshee", "chasm crawler",
"Screaming twisted banshee", "screaming banshee",
"Giant rockslug", "screaming twisted banshee",
"Cockathrice", "giant rockslug",
"Flaming pyrelord", "cockathrice",
"Monstrous basilisk", "flaming pyrelord",
"Malevolent mage", "monstrous basilisk",
"Insatiable bloodveld", "malevolent mage",
"Insatiable mutated bloodveld", "insatiable bloodveld",
"Vitreous jelly", "insatiable mutated bloodveld",
"Vitreous warped jelly", "vitreous jelly",
"Cave abomination", "vitreous warped jelly",
"Abhorrent spectre", "cave abomination",
"Repugnant spectre", "abhorrent spectre",
"Choke devil", "repugnant spectre",
"King kurask", "choke devil",
"Marble gargoyle", "king kurask",
"Nechryarch", "marble gargoyle",
"Greater abyssal demon", "nechryarch",
"Night beast", "greater abyssal demon",
"Nuclear smoke devil"); "night beast",
"nuclear smoke devil");
static
{
SUPERIOR_SLAYER_MONSTERS = SUPERIOR_SLAYER_MONSTERS.stream().map(name -> name.toLowerCase()).collect(Collectors.toList());
}
@Inject @Inject
private Client client; private Client client;

9
runelite-client/src/test/java/net/runelite/client/plugins/slayer/SlayerPluginTest.java
View File

@@ -561,4 +561,13 @@ public class SlayerPluginTest
verify(chatMessageManager, never()).update(any(MessageNode.class)); verify(chatMessageManager, never()).update(any(MessageNode.class));
} }
@Test
public void testSuperiorsLowercase()
{
for (String name : SlayerPlugin.SUPERIOR_SLAYER_MONSTERS)
{
assertEquals(name, name.toLowerCase());
}
}
} }