ra/runelite
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

remove static block initialization of superior list

Browse Source
This commit is contained in:
Davis Cook
2019-02-12 01:11:06 -05:00
parent 1cf7801045
commit 0baf0a8ecb
2 changed files with 34 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

54
runelite-client/src/main/java/net/runelite/client/plugins/slayer/SlayerPlugin.java
View File

@@ -127,35 +127,31 @@ public class SlayerPlugin extends Plugin
private static final int TASK_STRING_MAX_LENGTH = 50;
// Superiors
private static List<String> SUPERIOR_SLAYER_MONSTERS = Arrays.asList(
"Crushing hand",
"Chasm crawler",
"Screaming banshee",
"Screaming twisted banshee",
"Giant rockslug",
"Cockathrice",
"Flaming pyrelord",
"Monstrous basilisk",
"Malevolent mage",
"Insatiable bloodveld",
"Insatiable mutated bloodveld",
"Vitreous jelly",
"Vitreous warped jelly",
"Cave abomination",
"Abhorrent spectre",
"Repugnant spectre",
"Choke devil",
"King kurask",
"Marble gargoyle",
"Nechryarch",
"Greater abyssal demon",
"Night beast",
"Nuclear smoke devil");
static
{
SUPERIOR_SLAYER_MONSTERS = SUPERIOR_SLAYER_MONSTERS.stream().map(name -> name.toLowerCase()).collect(Collectors.toList());
}
@VisibleForTesting
static List<String> SUPERIOR_SLAYER_MONSTERS = Arrays.asList(
"crushing hand",
"chasm crawler",
"screaming banshee",
"screaming twisted banshee",
"giant rockslug",
"cockathrice",
"flaming pyrelord",
"monstrous basilisk",
"malevolent mage",
"insatiable bloodveld",
"insatiable mutated bloodveld",
"vitreous jelly",
"vitreous warped jelly",
"cave abomination",
"abhorrent spectre",
"repugnant spectre",
"choke devil",
"king kurask",
"marble gargoyle",
"nechryarch",
"greater abyssal demon",
"night beast",
"nuclear smoke devil");
@Inject
private Client client;

9
runelite-client/src/test/java/net/runelite/client/plugins/slayer/SlayerPluginTest.java
View File

@@ -561,4 +561,13 @@ public class SlayerPluginTest
verify(chatMessageManager, never()).update(any(MessageNode.class));
}
@Test
public void testSuperiorsLowercase()
{
for (String name : SlayerPlugin.SUPERIOR_SLAYER_MONSTERS)
{
assertEquals(name, name.toLowerCase());
}
}
}