Commit Graph

1819 Commits

Author SHA1 Message Date
Levi Schuck
b52025ae72 Fix negative total XP calculation when skill starts
Closes #1734

Summary:
If you start a skill like fishing lobster after logging in,
you will have the xpGained value as `90`.
But, since you just started the skill, it will divide by `0`.
This results in the max integer value of `2147483647`.

If you did fletching before fishing, and had a XP per hour of `40000`.
Then when you add the fishing XP per hour of `2147483647`, the
result overflows and you get a negative number as the total XP per hour.

Solution:
Don't divide by zero, instead suppose that the skill has been active
for **at least** 60 seconds. This will result in a fair estimate that
improves as the skill continues to be used, rather than the ridiculous
estimate of 2 Billion one second and 200K the next second.

60 seconds is chosen over 1 or 5 or 10 seconds as the result is more
conservative and closer matches my hourly XP experiences.
2018-05-02 17:42:46 -05:00
Levi
443cc7569f xp tracker: rewrite tracking datastructures
Fix showing inaccurate "actions left" number #1735 
Fix tracker confusing switching accounts with xp gain #1273
2018-05-01 20:00:52 -04:00
Kamiel
a66c3fc6e7 Add 3rd Age Axe and 3rd Age Pickaxe animations to Idle Notifier 2018-05-01 19:38:01 -04:00
Kamiel
a7cbda46d8 Add logger command to change the logger level 2018-05-01 19:16:18 -04:00
Kamiel
e98304b536 Add gfx command to developer tools
Setting the spotAnimFrame to 0 is required to play the graphic from the start
2018-05-01 19:16:18 -04:00
Kamiel
acfba42295 Add anim command to developer tools
It is required to set the action frame to 0 else the animation will not play from the beginning
2018-05-01 19:16:17 -04:00
Samuel Beresford
a557fc7f25 Adds skill progress bar to hiscore panel
Matches existing progress bar (look&feel) as xp tracker
2018-05-01 18:00:53 -04:00
Adam
e5f010d75c Merge pull request #2189 from Rprrr/brothertranq
Brother Tranquility 'talk-to' & ''transport' option swap
2018-05-01 13:04:13 -04:00
Adam
2082010420 Merge pull request #2196 from NotFoxtrot/fix-master-clue-emote-entrana-church
Fix master clue emote: Entrana church
2018-05-01 12:17:04 -04:00
Adam
808260ecc8 Merge pull request #2206 from FatalWaffles/patch-1
Fix Beckon in Digsite clue location
2018-05-01 12:07:55 -04:00
Adam
63ec836dbf Merge pull request #2201 from Abextm/farm-tele
farmingtracker: Prevent saving when teleporting
2018-05-01 08:29:01 -04:00
u6077743
26ddd58da0 Improved low hp notif. by considering nmz absorption, 2210 2018-05-01 08:10:59 -04:00
FatalWaffles
67801c79cd Fix Beckon in Digsite location
Change worldpoint for Beckon in digsite location to be accurate.
2018-04-30 22:36:57 -04:00
Max Weber
f3a8cd9ba9 farmingtracker: Prevent saving when teleporting
When teleporting to a updating region (ardy teleport), it would save the new region's varbits to the old region's config.
2018-04-30 18:14:59 -06:00
Max Weber
efa67d7c93 Rename SettingsTracker 2018-04-30 16:27:52 -06:00
Max Weber
7f190f2534 Merge Varcs into Client::getVar 2018-04-30 16:17:04 -06:00
Max Weber
33d6b9bdb7 Rename Setting to VarPlayer 2018-04-30 16:03:49 -06:00
Maiddog
41342be02d Fix various clue objects and locations. 2018-04-30 17:17:01 -04:00
NotFoxtrot
e3ac212822 Fix master clue emote: Entrana church 2018-04-30 22:52:19 +02:00
Adam
dc1125a49c Merge pull request #2191 from NotFoxtrot/fix-elite-clue-cryptic-father-aereck
Fix cryptic elite clue: Father Aereck
2018-04-30 16:01:44 -04:00
Adam
1bf50fe194 Merge pull request #2143 from Nightfirecat/fix-shayzien-command-tent-emote-clue
Fix Shayzien command tent emote clue
2018-04-30 15:58:49 -04:00
NotFoxtrot
d1d394a259 Fix cryptic elite clue: Father Aereck 2018-04-30 20:37:31 +02:00
Rprrr
b7f62437be Fixes #2146 (Brother Tranquility 'talk-to' & ''transport' option swap w/Menu Swapper plugin) 2018-04-30 19:45:12 +02:00
Rprrr
31c27292e0 screenshot plugin: fix exception when taking screenshots on login 2018-04-30 12:48:51 -04:00
Adam
c8b5a3a3a3 Merge pull request #2167 from bkase/fix-stomp-emote-clue
Adjust stomp dragon-axe clue location
2018-04-30 12:41:08 -04:00
Adam
c0ea5d0dd0 Merge pull request #2169 from bkase/fix-wildy-cryptic
Add missing comma to hard cryptic
2018-04-30 12:37:30 -04:00
Adam
d4ef4ec78f Merge pull request #2170 from Nightfirecat/fix-hard-cryptic-clue
Fix hard cryptic clue
2018-04-30 12:27:51 -04:00
Lotto
b23880d273 cluescrolls: support any type of ring of dueling in emote clues 2018-04-30 12:43:27 +02:00
Tomas Slusny
73c54db006 Merge pull request #2022 from sethtroll/addhintarrowtoggle
clue scroll: Add toggle for hint arrows
2018-04-30 11:49:18 +02:00
Tomas Slusny
5fdfaa28e9 Merge pull request #2137 from sethtroll/resetprogresscolor
farming panel: reset progress bar background
2018-04-30 11:47:59 +02:00
Jordan Atwood
d36bcf879e Fix hard cryptic clue
Fixed clue string, punctuation in instructions.
Ref: https://user-images.githubusercontent.com/2199511/39418034-7f2b38a4-4c47-11e8-9691-9cf384bf4d7f.png
2018-04-30 00:24:39 -07:00
Brandon Kase
8a7f90f016 Add missing comma to hard cryptic 2018-04-30 00:10:31 -07:00
Brandon Kase
aadfa35bf6 Adjust stomp dragon-axe clue location 2018-04-29 22:36:13 -07:00
Adam
ff89cac97e demonic gorilla plugin: use headicon api 2018-04-29 19:42:54 -04:00
Jordan Atwood
36805b4883 Fix Shayzien command tent emote clue
Fixes punctuation (no oxford comma)
Ref: https://user-images.githubusercontent.com/2199511/39410263-0c98ddbc-4be5-11e8-94b0-f7d4d5527e08.png
2018-04-29 12:42:49 -07:00
Adam
b93ef7362f Merge pull request #2042 from jpabeem/XpGlobe-stays-on-screen-while-hovered-over-it
Fix XpGlobe: now stays on screen while hovered over it
2018-04-29 15:10:09 -04:00
Adam
af92b647e9 Merge pull request #2071 from SoyChai/typos
Minor typo corrections
2018-04-29 15:00:59 -04:00
Seth
28b50e3f30 farming panel: reset progress bar background
fixes progress bar background not resetting when state = null
2018-04-29 13:33:18 -05:00
Adam
23db84deb6 Merge pull request #2126 from deathbeam/cerberus-ghosts
Add Cerberus plugin
2018-04-29 14:29:24 -04:00
Adam
87da5aed68 devtools: add addxp 2018-04-29 14:21:53 -04:00
Seth
6b3ddac948 clue scroll: fix easy clue 2018-04-29 13:00:29 -05:00
Seth
ef01b3c3db clue scroll: add toggle for hint arrows 2018-04-29 13:00:29 -05:00
Tomas Slusny
ed32646b52 Add Cerberus plugin
Add Cerberus plugin that will show order of ghosts in bottom right
corner.

Signed-off-by: Tomas Slusny <slusnucky@gmail.com>
2018-04-29 19:34:02 +02:00
Adam
23c7701f65 runelite: add --disable-update-check 2018-04-29 13:08:35 -04:00
Adam
c567ca277a runelite: fix check for client before requesting itemmanager
If outdated, this.client is null but client is not null. Invoking get() on the item manager provider will make guice late construct it and it has a dependency on client.
2018-04-29 13:08:35 -04:00
Maiddog
1ad35ff2d1 clues: change npc name check to nameEquals 2018-04-29 12:20:21 -04:00
Adam
320e92ac1c Merge pull request #2124 from SoyChai/discord-skilling-icons
Display skill icons in Discord while training
2018-04-29 12:05:52 -04:00
SoyChai
e22f19ac6e discord: Display skill icons in Discord while training 2018-04-29 22:48:26 +10:00
Lotto
9b4b42d8ac Merge pull request #2059 from deathbeam/fix-emote-clue-platelegs-platebody
Fix clue requiring platebody, but wanting legs
2018-04-29 14:37:50 +02:00
Maiddog
999f4cc971 clues: fix spotted cape not being detected 2018-04-28 22:21:30 -04:00