ra/runelite
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

examine plugin: fix overflow in computing alch price

Browse Source
This commit is contained in:
Adam
2020-06-27 13:52:14 -04:00
parent 71d89af946
commit f9aea0d958
2 changed files with 28 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
runelite-client/src/main/java/net/runelite/client/plugins/examine/ExaminePlugin.java
View File

@@ -24,6 +24,7 @@
*/
package net.runelite.client.plugins.examine;
import com.google.common.annotations.VisibleForTesting;
import com.google.common.cache.Cache;
import com.google.common.cache.CacheBuilder;
import java.time.Instant;
@@ -313,11 +314,12 @@ public class ExaminePlugin extends Plugin
return null;
}
private void getItemPrice(int id, ItemComposition itemComposition, int quantity)
@VisibleForTesting
void getItemPrice(int id, ItemComposition itemComposition, int quantity)
{
// quantity is at least 1
quantity = Math.max(1, quantity);
final long gePrice = itemManager.getItemPrice(id);
final int gePrice = itemManager.getItemPrice(id);
final int alchPrice = itemComposition.getHaPrice();
if (gePrice > 0 || alchPrice > 0)
@@ -345,7 +347,7 @@ public class ExaminePlugin extends Plugin
.append(ChatColorType.NORMAL)
.append(" GE average ")
.append(ChatColorType.HIGHLIGHT)
.append(QuantityFormatter.formatNumber(gePrice * quantity));
.append(QuantityFormatter.formatNumber((long) gePrice * quantity));
if (quantity > 1)
{
@@ -365,7 +367,7 @@ public class ExaminePlugin extends Plugin
.append(ChatColorType.NORMAL)
.append(" HA value ")
.append(ChatColorType.HIGHLIGHT)
.append(QuantityFormatter.formatNumber(alchPrice * quantity));
.append(QuantityFormatter.formatNumber((long) alchPrice * quantity));
if (quantity > 1)
{