ra/runelite
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

container calculation: fix overflow computing ge price

Browse Source
This commit is contained in:
Adam
2019-11-01 10:14:44 -04:00
parent 3a00ecbc24
commit ec0858548f
2 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
runelite-client/src/main/java/net/runelite/client/plugins/bank/ContainerCalculation.java
View File

@@ -86,7 +86,7 @@ class ContainerCalculation
final long storePrice = itemManager.getItemComposition(id).getPrice(); final long storePrice = itemManager.getItemComposition(id).getPrice();
final long alchPrice = (long) (storePrice * Constants.HIGH_ALCHEMY_MULTIPLIER); final long alchPrice = (long) (storePrice * Constants.HIGH_ALCHEMY_MULTIPLIER);
alch += alchPrice * qty; alch += alchPrice * qty;
ge += itemManager.getItemPrice(id) * qty; ge += (long) itemManager.getItemPrice(id) * qty;
break; break;
} }

6
runelite-client/src/test/java/net/runelite/client/plugins/bank/ContainerCalculationTest.java
View File

@@ -81,11 +81,13 @@ public class ContainerCalculationTest
.thenReturn(7); // 7 * .6 = 4, 4 * 1m overflows .thenReturn(7); // 7 * .6 = 4, 4 * 1m overflows
when(itemManager.getItemComposition(ItemID.ABYSSAL_WHIP)) when(itemManager.getItemComposition(ItemID.ABYSSAL_WHIP))
.thenReturn(whipComp); .thenReturn(whipComp);
when(itemManager.getItemPrice(ItemID.ABYSSAL_WHIP))
.thenReturn(3); // 1b * 3 overflows
final ContainerPrices prices = containerCalculation.calculate(items); final ContainerPrices prices = containerCalculation.calculate(items);
assertNotNull(prices); assertNotNull(prices);
long value = prices.getHighAlchPrice(); assertTrue(prices.getHighAlchPrice() > Integer.MAX_VALUE);
assertTrue(value > Integer.MAX_VALUE); assertTrue(prices.getGePrice() > Integer.MAX_VALUE);
} }
} }