ra/runelite
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

Reduce code duplicity in resetOverlay method

Browse Source 
Use saveOverlay and null all fields to achieve same result.

Signed-off-by: Tomas Slusny <slusnucky@gmail.com>
This commit is contained in:
Tomas Slusny
2018-06-15 10:14:57 +02:00
parent 3cdc2be72f
commit ea051beb4e
2 changed files with 4 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
runelite-client/src/main/java/net/runelite/client/ui/overlay/OverlayManager.java
View File

@@ -191,13 +191,10 @@ public class OverlayManager
*/ */
public synchronized void resetOverlay(final Overlay overlay) public synchronized void resetOverlay(final Overlay overlay)
{ {
final String locationKey = overlay.getName() + OVERLAY_CONFIG_PREFERRED_LOCATION; overlay.setPreferredPosition(null);
final String positionKey = overlay.getName() + OVERLAY_CONFIG_PREFERRED_POSITION; overlay.setPreferredSize(null);
final String sizeKey = overlay.getName() + OVERLAY_CONFIG_PREFERRED_SIZE; overlay.setPreferredLocation(null);
configManager.unsetConfiguration(RUNELITE_CONFIG_GROUP_NAME, locationKey); saveOverlay(overlay);
configManager.unsetConfiguration(RUNELITE_CONFIG_GROUP_NAME, positionKey);
configManager.unsetConfiguration(RUNELITE_CONFIG_GROUP_NAME, sizeKey);
rebuildOverlayLayers();
} }
private synchronized void rebuildOverlayLayers() private synchronized void rebuildOverlayLayers()

3
runelite-client/src/main/java/net/runelite/client/ui/overlay/OverlayRenderer.java
View File

@@ -256,9 +256,6 @@ public class OverlayRenderer extends MouseListener implements KeyListener
// detached overlays have no place to reset back to // detached overlays have no place to reset back to
if (overlay.getPosition() != OverlayPosition.DETACHED) if (overlay.getPosition() != OverlayPosition.DETACHED)
{ {
overlay.setPreferredPosition(null);
overlay.setPreferredSize(null);
overlay.setPreferredLocation(null);
overlayManager.resetOverlay(overlay); overlayManager.resetOverlay(overlay);
} }
} }