tagtabs: split tag search from bank search

This fixes a lot of edge cases which required us to re-search for things
after input was re-used when a tag tab was open, and removes the
requirement of having the bank search text be in sync with the
currently selected tab.

This also no longer parses the tag tab out of the title during times
when the input is being re-used (like Withdraw-x) which was broken
earlier from the bank plugin changing the title to include the value of
searches.

A new tag tab title is being set now on all tag tab views so the old tag
tab tab title event can be removed.

runelite-client/src/main/scripts/BankSearchFilter.rs2asm

@@ -10,6 +10,16 @@
    invoke                 514
    iconst                 1
    if_icmpeq              LABEL8
+
+   iconst                 1                  ; return value - default to true to match anything
+   iload                  0                  ; load item id
+   sconst                 ""                 ; we are not searching, so there is no search string
+   sconst                 "bankSearchFilter" ; push event name
+   runelite_callback                         ; invoke callback
+   pop_int                                   ; pop item id
+   pop_string                                ; pop search string
+   return                                    ; return rv
+
    jump                   LABEL34
 LABEL8:
    get_varc_string        359                ; Skip truncating of varcstr 22 by not calling 280
@@ -32,13 +42,11 @@ LABEL19:
    sstore                 0
    iconst                 -1                 ; load return value
    iload                  0                  ; load item id
-   sload                  0                  ; load item name
    sload                  1                  ; load search string
    sconst                 "bankSearchFilter" ; push event name
    runelite_callback     ; invoke callback
    pop_int               ; pop item id
    pop_string            ; pop search string
-   pop_string            ; pop item name
    istore                 1 ; store return value for the below comparisons
    iload                  1
    iconst                 0

runelite-client/src/main/scripts/BankSearchLayout.rs2asm

@@ -10,9 +10,6 @@
 ; callback "setBankScroll"
 ;	Fired before bank is calculated
 ;   Used by the TabInterface to show fake bank items for tag tabs
-;
-; callback "isTabMenuActive"
-;	Used by the TabInterface to skip setting the bank title
    sconst                 "beforeBankLayout"
    runelite_callback     
    get_varbit             5102
@@ -966,12 +963,6 @@ LABEL848:
    add                   
    istore                 20
    jump                   LABEL769
-SetTitle:
-   iconst                 0                  ; Compare variable
-   iconst                 0                  ;
-   sconst                 "isTabMenuActive"
-   runelite_callback     ; skip setting the bank title if the tag tab menu is active
-   if_icmpne              FinishBuilding
 LABEL853:
    get_varbit             4170
    iconst                 2