From e3163c80ae7f34ca95b34973bc7c79a60b95600d Mon Sep 17 00:00:00 2001 From: Adam Date: Fri, 3 Jul 2020 17:51:08 -0400 Subject: [PATCH] plugin manager: remove extra injectMembers() call This has been here a long time, but as far as we can tell is no longer necessary. It is causing double instantiation of classes which are only injected a single place. --- .../src/main/java/net/runelite/client/plugins/PluginManager.java | 1 - 1 file changed, 1 deletion(-) diff --git a/runelite-client/src/main/java/net/runelite/client/plugins/PluginManager.java b/runelite-client/src/main/java/net/runelite/client/plugins/PluginManager.java index d3f430259b..4aeb37b213 100644 --- a/runelite-client/src/main/java/net/runelite/client/plugins/PluginManager.java +++ b/runelite-client/src/main/java/net/runelite/client/plugins/PluginManager.java @@ -525,7 +525,6 @@ public class PluginManager binder.install(plugin); }; Injector pluginInjector = parent.createChildInjector(pluginModule); - pluginInjector.injectMembers(plugin); plugin.injector = pluginInjector; } catch (CreationException ex)