ra/runelite
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

runelite-client: Make OverlayManager thread safe

Browse Source 
There was something happening where rebuildOverlayLayers would race itself almost 100% of the time, preventing overlays from being removed.
This commit is contained in:
Max Weber
2018-06-12 20:49:29 -06:00
committed by Abex
parent e94beb922b
commit e0d70ab382
3 changed files with 89 additions and 80 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
runelite-client/src/test/java/net/runelite/client/ui/overlay/OverlayManagerTest.java
View File

@@ -55,7 +55,7 @@ public class OverlayManagerTest
Overlay tlh = new TestOverlay(OverlayPosition.TOP_LEFT, OverlayPriority.HIGH);
Overlay tll = new TestOverlay(OverlayPosition.TOP_LEFT, OverlayPriority.LOW);
List<Overlay> overlays = Arrays.asList(tlh, tll);
OverlayManager.sortOverlays(overlays);
overlays.sort(OverlayManager.OVERLAY_COMPARATOR);
assertEquals(tlh, overlays.get(0));
assertEquals(tll, overlays.get(1));
}
@@ -67,7 +67,7 @@ public class OverlayManagerTest
Overlay tlh = new TestOverlay(OverlayPosition.TOP_LEFT, OverlayPriority.HIGH);
Overlay dyn = new TestOverlay(OverlayPosition.DYNAMIC, OverlayPriority.HIGH);
List<Overlay> overlays = Arrays.asList(tlh, dyn);
OverlayManager.sortOverlays(overlays);
overlays.sort(OverlayManager.OVERLAY_COMPARATOR);
assertEquals(dyn, overlays.get(0));
assertEquals(tlh, overlays.get(1));
}
@@ -80,7 +80,7 @@ public class OverlayManagerTest
Overlay dyn = new TestOverlay(OverlayPosition.DYNAMIC, OverlayPriority.HIGH);
Overlay tlh = new TestOverlay(OverlayPosition.TOP_LEFT, OverlayPriority.HIGH);
List<Overlay> overlays = Arrays.asList(t, dyn, tlh);
OverlayManager.sortOverlays(overlays);
overlays.sort(OverlayManager.OVERLAY_COMPARATOR);
assertEquals(dyn, overlays.get(0));
assertEquals(tlh, overlays.get(1));
assertEquals(t, overlays.get(2));