rs-client: refactoring (#1344)

* Rename some things to be more consistent everywhere

* rs-client: refactoring

* MenuAction -> MenuOpcode merge

runescape-api/src/main/java/net/runelite/rs/api/RSBoundaryObject.java

@@ -27,11 +27,11 @@ public interface RSBoundaryObject extends WallObject
 
 	@Import("entity1")
 	@Override
-	RSEntity getRenderable1();
+	RSEntity getEntity1();
 
 	@Import("entity2")
 	@Override
-	RSEntity getRenderable2();
+	RSEntity getEntity2();
 
 	@Import("flags")
 	@Override

runescape-api/src/main/java/net/runelite/rs/api/RSClient.java

@@ -308,25 +308,25 @@ public interface RSClient extends RSGameShell, Client
 	@Import("menuActions")
 	String[] getMenuOptions();
 
-	@Import("menuTargetNames")
+	@Import("menuTargets")
 	String[] getMenuTargets();
 
-	@Import("menuArguments0")
+	@Import("menuIdentifiers")
 	int[] getMenuIdentifiers();
 
 	@Import("menuOpcodes")
-	int[] getMenuTypes();
+	int[] getMenuOpcodes();
 
 	@Import("menuArguments1")
-	int[] getMenuActionParams0();
+	int[] getMenuArguments1();
 
 	@Import("menuArguments2")
-	int[] getMenuActionParams1();
+	int[] getMenuArguments2();
 
 	@Import("menuShiftClick")
 	boolean[] getMenuForceLeftClick();
 
-	@Import("worlds")
+	@Import("World_worlds")
 	@Override
 	RSWorld[] getWorldList();
 
@@ -384,7 +384,7 @@ public interface RSClient extends RSGameShell, Client
 	@Import("itemContainers")
 	RSNodeHashTable getItemContainers();
 
-	@Import("getItemDefinition")
+	@Import("ItemDefinition_get")
 	@Override
 	RSItemDefinition getItemDefinition(int itemId);
 
@@ -603,15 +603,12 @@ public interface RSClient extends RSGameShell, Client
 	@Import("Scene_isLowDetail")
 	void setSceneLowMemory(boolean lowMemory);
 
-	@Import("isStereo")
+	@Import("PcmPlayer_stereo")
 	void setAudioHighMemory(boolean highMemory);
 
 	@Import("ObjectDefinition_isLowDetail")
 	void setObjectDefinitionLowDetail(boolean lowDetail);
 
-	@Construct
-	RSTileItem createItem();
-
 	@Import("Interpreter_intStackSize")
 	@Override
 	int getIntStackSize();

runescape-api/src/main/java/net/runelite/rs/api/RSFloorDecoration.java

@@ -17,7 +17,7 @@ public interface RSFloorDecoration extends GroundObject
 
 	@Import("entity")
 	@Override
-	RSEntity getRenderable();
+	RSEntity getEntity();
 
 	void setPlane(int plane);
 }

runescape-api/src/main/java/net/runelite/rs/api/RSGameObject.java

@@ -6,7 +6,7 @@ import net.runelite.mapping.Import;
 public interface RSGameObject extends GameObject
 {
 	@Import("entity")
-	RSEntity getRenderable();
+	RSEntity getEntity();
 
 	@Import("plane")
 	int getPlane();

runescape-api/src/main/java/net/runelite/rs/api/RSTextureProvider.java

@@ -23,7 +23,7 @@ public interface RSTextureProvider extends TextureProvider
 	@Override
 	RSTexture[] getTextures();
 
-	@Import("load")
+	@Import("getTexturePixels")
 	@Override
 	int[] load(int textureId);
 }

runescape-api/src/main/java/net/runelite/rs/api/RSTile.java

@@ -34,11 +34,11 @@ public interface RSTile extends Tile
 
 	@Import("paint")
 	@Override
-	TilePaint getSceneTilePaint();
+	TilePaint getTilePaint();
 
 	@Import("model")
 	@Override
-	TileModel getSceneTileModel();
+	TileModel getTileModel();
 
 	@Import("x")
 	int getX();

runescape-api/src/main/java/net/runelite/rs/api/RSWallDecoration.java

@@ -26,11 +26,11 @@ public interface RSWallDecoration extends DecorativeObject
 
 	@Import("entity1")
 	@Override
-	RSEntity getRenderable();
+	RSEntity getEntity1();
 
 	@Import("entity2")
 	@Override
-	RSEntity getRenderable2();
+	RSEntity getEntity2();
 
 	void setPlane(int plane);
 }