From d8ba9b13ba28eb29c6bf93a10b366f9b9eeac4b1 Mon Sep 17 00:00:00 2001 From: Adam Date: Sun, 13 Mar 2022 17:00:14 -0400 Subject: [PATCH] loottracker: replace repaint calls with revalidate This fixes removing panels from the logs container not correctly rebuilding the container to remove the space the box was previously in --- .../runelite/client/plugins/loottracker/LootTrackerBox.java | 5 ++--- .../client/plugins/loottracker/LootTrackerPanel.java | 5 ++--- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/runelite-client/src/main/java/net/runelite/client/plugins/loottracker/LootTrackerBox.java b/runelite-client/src/main/java/net/runelite/client/plugins/loottracker/LootTrackerBox.java index 36d784c182..2706162318 100644 --- a/runelite-client/src/main/java/net/runelite/client/plugins/loottracker/LootTrackerBox.java +++ b/runelite-client/src/main/java/net/runelite/client/plugins/loottracker/LootTrackerBox.java @@ -242,8 +242,7 @@ class LootTrackerBox extends JPanel subTitleLabel.setToolTipText(QuantityFormatter.formatNumber(totalPrice / kills) + " gp (average)"); } - validate(); - repaint(); + revalidate(); } void collapse() @@ -368,7 +367,7 @@ class LootTrackerBox extends JPanel itemContainer.add(slotContainer); } - itemContainer.repaint(); + itemContainer.revalidate(); } private static String buildToolTip(LootTrackerItem item) diff --git a/runelite-client/src/main/java/net/runelite/client/plugins/loottracker/LootTrackerPanel.java b/runelite-client/src/main/java/net/runelite/client/plugins/loottracker/LootTrackerPanel.java index 9ac6ac53ce..8dc0edabac 100644 --- a/runelite-client/src/main/java/net/runelite/client/plugins/loottracker/LootTrackerPanel.java +++ b/runelite-client/src/main/java/net/runelite/client/plugins/loottracker/LootTrackerPanel.java @@ -331,7 +331,7 @@ class LootTrackerPanel extends PluginPanel boxes.removeIf(b -> b.matches(currentView, currentType)); updateOverall(); logsContainer.removeAll(); - logsContainer.repaint(); + logsContainer.revalidate(); // Delete all loot, or loot matching the current view if (currentView != null) @@ -537,7 +537,6 @@ class LootTrackerPanel extends PluginPanel boxes.forEach(LootTrackerBox::rebuild); updateOverall(); logsContainer.revalidate(); - logsContainer.repaint(); } /** @@ -638,7 +637,7 @@ class LootTrackerPanel extends PluginPanel boxes.remove(box); updateOverall(); logsContainer.remove(box); - logsContainer.repaint(); + logsContainer.revalidate(); // Without loot being grouped we have no way to identify single kills to be deleted if (groupLoot)