ra/runelite
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

idle notifier: Support filling water vessels, Shades of Mort'ton

Browse Source 
LOOKING_INTO is a generic animation used for numerous activities, and
was previously used as an intermediate animation in a test case. Now
that it is used to trigger idle notifications, a dummy animation has
been inserted to ensure the affected test case will not be broken in the
same way in the future.

Co-authored-by: Nick Wolff <nickwolff2@gmail.com>
Co-authored-by: Arnaud Peralta <arnaud.peralta@gmail.com>
This commit is contained in:
Jordan Atwood
2021-09-13 23:30:04 -07:00
parent 51f484da2e
commit d58cecdb8d
3 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
runelite-api/src/main/java/net/runelite/api/AnimationID.java
View File

@@ -179,7 +179,7 @@ public final class AnimationID
public static final int MAGIC_ENCHANTING_BOLTS = 4462; public static final int MAGIC_ENCHANTING_BOLTS = 4462;
public static final int BURYING_BONES = 827; public static final int BURYING_BONES = 827;
public static final int USING_GILDED_ALTAR = 3705; public static final int USING_GILDED_ALTAR = 3705;
public static final int LOOKING_INTO = 832; public static final int LOOKING_INTO = 832; // Generic animation used for filling water vessels, Shades of Mort'ton, etc.
public static final int DIG = 830; public static final int DIG = 830;
public static final int DEMONIC_GORILLA_MAGIC_ATTACK = 7225; public static final int DEMONIC_GORILLA_MAGIC_ATTACK = 7225;
public static final int DEMONIC_GORILLA_MELEE_ATTACK = 7226; public static final int DEMONIC_GORILLA_MELEE_ATTACK = 7226;

1
runelite-client/src/main/java/net/runelite/client/plugins/idlenotifier/IdleNotifierPlugin.java
View File

@@ -292,6 +292,7 @@ public class IdleNotifierPlugin extends Plugin
case PISCARILIUS_CRANE_REPAIR: case PISCARILIUS_CRANE_REPAIR:
case HOME_MAKE_TABLET: case HOME_MAKE_TABLET:
case SAND_COLLECTION: case SAND_COLLECTION:
case LOOKING_INTO:
resetTimers(); resetTimers();
lastAnimation = animation; lastAnimation = animation;
lastAnimating = Instant.now(); lastAnimating = Instant.now();

4
runelite-client/src/test/java/net/runelite/client/plugins/idlenotifier/IdleNotifierPluginTest.java
View File

@@ -62,6 +62,8 @@ import org.mockito.junit.MockitoJUnitRunner;
@RunWith(MockitoJUnitRunner.class) @RunWith(MockitoJUnitRunner.class)
public class IdleNotifierPluginTest public class IdleNotifierPluginTest
{ {
private static final int UNKNOWN_ANIMATION = -2;
@Mock @Mock
@Bind @Bind
private Client client; private Client client;
@@ -153,7 +155,7 @@ public class IdleNotifierPluginTest
animationChanged.setActor(player); animationChanged.setActor(player);
plugin.onAnimationChanged(animationChanged); plugin.onAnimationChanged(animationChanged);
plugin.onGameTick(new GameTick()); plugin.onGameTick(new GameTick());
when(player.getAnimation()).thenReturn(AnimationID.LOOKING_INTO); when(player.getAnimation()).thenReturn(UNKNOWN_ANIMATION);
plugin.onAnimationChanged(animationChanged); plugin.onAnimationChanged(animationChanged);
plugin.onGameTick(new GameTick()); plugin.onGameTick(new GameTick());
when(player.getAnimation()).thenReturn(AnimationID.IDLE); when(player.getAnimation()).thenReturn(AnimationID.IDLE);