cache: try-with-resources the rest of the Stores in tests

cache/src/test/java/net/runelite/cache/NpcDumperTest.java

@@ -46,17 +46,19 @@ public class NpcDumperTest
 		File dumpDir = folder.newFolder(),
 			javaDir = folder.newFolder();
 
-		Store store = new Store(StoreLocation.LOCATION);
+		try (Store store = new Store(StoreLocation.LOCATION))
-		store.load();
+		{
+			store.load();
 
-		NpcDumper dumper = new NpcDumper(
+			NpcDumper dumper = new NpcDumper(
-			store,
+				store,
-			dumpDir,
+				dumpDir,
-			javaDir
+				javaDir
-		);
+			);
-		dumper.load();
+			dumper.load();
-		dumper.dump();
+			dumper.dump();
-		dumper.java();
+			dumper.java();
+		}
 
 		logger.info("Dumped to {}, java {}", dumpDir, javaDir);
 	}

cache/src/test/java/net/runelite/cache/ObjectDumperTest.java

@@ -46,17 +46,19 @@ public class ObjectDumperTest
 		File dumpDir = folder.newFolder(),
 			javaDir = folder.newFolder();
 
-		Store store = new Store(StoreLocation.LOCATION);
+		try (Store store = new Store(StoreLocation.LOCATION))
-		store.load();
+		{
+			store.load();
 
-		ObjectDumper dumper = new ObjectDumper(
+			ObjectDumper dumper = new ObjectDumper(
-			store,
+				store,
-			dumpDir,
+				dumpDir,
-			javaDir
+				javaDir
-		);
+			);
-		dumper.load();
+			dumper.load();
-		dumper.dump();
+			dumper.dump();
-		dumper.java();
+			dumper.java();
+		}
 
 		logger.info("Dumped to {}, java {}", dumpDir, javaDir);
 	}

cache/src/test/java/net/runelite/cache/downloader/CacheClientTest.java

@@ -49,45 +49,49 @@ public class CacheClientTest
 	@Ignore
 	public void test() throws Exception
 	{
-		Store store = new Store(new File("d:/temp"));
+		try (Store store = new Store(new File("d:/temp")))
-		store.load();
+		{
+			store.load();
+			
+			CacheClient c = new CacheClient(store);
+			c.connect();
+			CompletableFuture<Integer> handshake = c.handshake();
 
-		CacheClient c = new CacheClient(store);
+			Integer result = handshake.get();
-		c.connect();
+			logger.info("Handshake result: {}", result);
-		CompletableFuture<Integer> handshake = c.handshake();
 
-		Integer result = handshake.get();
+			Assert.assertEquals(0, (int) result);
-		logger.info("Handshake result: {}", result);
+			
+			c.download();
 
-		Assert.assertEquals(0, (int) result);
+			c.close();
-
+			
-		c.download();
+			store.save();
-
+		}
-		c.close();
-
-		store.save();
 	}
 
 	@Test
 	@Ignore
 	public void testTree() throws Exception
 	{
-		Store store = new Store(new File("C:\\rs\\temp"));
+		try (Store store = new Store(new File("C:\\rs\\temp")))
-		store.loadTree(new File("C:\\rs\\runescape-data\\cache"));
+		{
+			store.loadTree(new File("C:\\rs\\runescape-data\\cache"));
+			
+			CacheClient c = new CacheClient(store);
+			c.connect();
+			CompletableFuture<Integer> handshake = c.handshake();
 
-		CacheClient c = new CacheClient(store);
+			Integer result = handshake.get();
-		c.connect();
+			logger.info("Handshake result: {}", result);
-		CompletableFuture<Integer> handshake = c.handshake();
 
-		Integer result = handshake.get();
+			Assert.assertEquals(0, (int) result);
-		logger.info("Handshake result: {}", result);
+			
+			c.download();
 
-		Assert.assertEquals(0, (int) result);
+			c.close();
-
+			
-		c.download();
+			store.saveTree(new File("C:\\rs\\temp\\t"));
-
+		}
-		c.close();
-
-		store.saveTree(new File("C:\\rs\\temp\\t"));
 	}
 }

cache/src/test/java/net/runelite/cache/fs/IndexFileTest.java

@@ -29,7 +29,6 @@ import java.io.File;
 import java.io.IOException;
 import net.runelite.cache.StoreLocation;
 import org.junit.Assert;
-import org.junit.BeforeClass;
 import org.junit.Rule;
 import org.junit.Test;
 import org.junit.rules.TemporaryFolder;
@@ -40,14 +39,16 @@ public class IndexFileTest
 	public TemporaryFolder folder = StoreLocation.getTemporaryFolder();
 	
 	@Test
-	public void test1() throws IOException
+	public void test() throws IOException
 	{
 		File file = folder.newFile();
-		Store store = new Store(folder.getRoot());
+		try (Store store = new Store(folder.getRoot()))
-		IndexFile index = new IndexFile(store, 5, file);
+		{
-		IndexEntry entry = new IndexEntry(index, 7, 8, 9);
+			IndexFile index = new IndexFile(store, 5, file);
-		index.write(entry);
+			IndexEntry entry = new IndexEntry(index, 7, 8, 9);
-		IndexEntry entry2 = index.read(7);
+			index.write(entry);
-		Assert.assertEquals(entry, entry2);
+			IndexEntry entry2 = index.read(7);
+			Assert.assertEquals(entry, entry2);
+		}
 	}
 }

cache/src/test/java/net/runelite/cache/fs/StoreLoadTest.java

@@ -52,24 +52,28 @@ public class StoreLoadTest
 	@Test
 	public void testSave() throws IOException
 	{
-		Store store = new Store(StoreLocation.LOCATION);
+		try (Store store = new Store(StoreLocation.LOCATION))
-		store.load();
-
-		java.io.File testStoreFile = folder.newFolder();
-		for (java.io.File f : StoreLocation.LOCATION.listFiles())
 		{
-			Files.copy(f, new java.io.File(testStoreFile, f.getName()));
+			store.load();
+
+			java.io.File testStoreFile = folder.newFolder();
+			for (java.io.File f : StoreLocation.LOCATION.listFiles())
+			{
+				Files.copy(f, new java.io.File(testStoreFile, f.getName()));
+			}
+
+			try (Store testStore = new Store(testStoreFile))
+			{
+				testStore.load();
+
+				Assert.assertTrue(store.equals(testStore));
+
+				testStore.save();
+				testStore.load();
+
+				Assert.assertTrue(store.equals(testStore));
+			}
 		}
-
-		Store testStore = new Store(testStoreFile);
-		testStore.load();
-
-		Assert.assertTrue(store.equals(testStore));
-
-		testStore.save();
-		testStore.load();
-
-		Assert.assertTrue(store.equals(testStore));
 	}
 
 	@Test