runelite-client: add runnable exception logger and use it in the zulrah plugin

runelite-client/src/main/java/net/runelite/client/plugins/zulrah/Zulrah.java

@@ -45,6 +45,7 @@ import net.runelite.client.plugins.zulrah.patterns.ZulrahPatternB;
 import net.runelite.client.plugins.zulrah.patterns.ZulrahPatternC;
 import net.runelite.client.plugins.zulrah.patterns.ZulrahPatternD;
 import net.runelite.client.ui.overlay.Overlay;
+import net.runelite.client.util.RunnableExceptionLogger;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
@@ -81,7 +82,7 @@ public class Zulrah extends Plugin
 	protected void startUp() throws Exception
 	{
 		ScheduledExecutorService executor = RuneLite.getRunelite().getExecutor();
-		future = executor.scheduleAtFixedRate(this::update, 100, 100, TimeUnit.MILLISECONDS);
+		future = executor.scheduleAtFixedRate(RunnableExceptionLogger.wrap(this::update), 100, 100, TimeUnit.MILLISECONDS);
 	}
 
 	@Override
@@ -97,8 +98,6 @@ public class Zulrah extends Plugin
 			return;
 		}
 
-		try
-		{
 		NPC zulrah = findZulrah();
 
 		if (zulrah == null)
@@ -172,13 +171,6 @@ public class Zulrah extends Plugin
 				}
 			}
 		}
-
-		}
-		catch (Exception ex)
-		{
-			logger.debug(null, ex);
-		}
-
 	}
 
 	private NPC findZulrah()

runelite-client/src/main/java/net/runelite/client/util/RunnableExceptionLogger.java

@@ -0,0 +1,58 @@
+/*
+ * Copyright (c) 2017, Adam <Adam@sigterm.info>
+ * All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are met:
+ *
+ * 1. Redistributions of source code must retain the above copyright notice, this
+ *    list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright notice,
+ *    this list of conditions and the following disclaimer in the documentation
+ *    and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND
+ * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
+ * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+ * DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR
+ * ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
+ * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
+ * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
+ * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
+ * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+package net.runelite.client.util;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+public class RunnableExceptionLogger implements Runnable
+{
+	private static final Logger logger = LoggerFactory.getLogger(RunnableExceptionLogger.class);
+
+	private final Runnable runnable;
+
+	private RunnableExceptionLogger(Runnable runnable)
+	{
+		this.runnable = runnable;
+	}
+
+	@Override
+	public void run()
+	{
+		try
+		{
+			runnable.run();
+		}
+		catch (Throwable ex)
+		{
+			logger.warn("Uncaught exception in runnable {}", runnable, ex);
+		}
+	}
+
+	public static RunnableExceptionLogger wrap(Runnable runnable)
+	{
+		return new RunnableExceptionLogger(runnable);
+	}
+}