From bd1cdc90ac82126aeb8b8c934c69e6f0ab7c99c7 Mon Sep 17 00:00:00 2001 From: Jordan Atwood Date: Thu, 26 May 2022 09:35:56 -0700 Subject: [PATCH] item stats: Clean up saradomin brew code --- .../plugins/itemstats/potions/SaradominBrew.java | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/runelite-client/src/main/java/net/runelite/client/plugins/itemstats/potions/SaradominBrew.java b/runelite-client/src/main/java/net/runelite/client/plugins/itemstats/potions/SaradominBrew.java index 2eaea550f4..5baa696909 100644 --- a/runelite-client/src/main/java/net/runelite/client/plugins/itemstats/potions/SaradominBrew.java +++ b/runelite-client/src/main/java/net/runelite/client/plugins/itemstats/potions/SaradominBrew.java @@ -57,9 +57,8 @@ public class SaradominBrew implements Effect SimpleStatBoost hitpoints = new SimpleStatBoost(HITPOINTS, true, perc(percH, deltaB)); SimpleStatBoost defence = new SimpleStatBoost(DEFENCE, true, perc(percD, deltaB)); BoostedStatBoost calc = new BoostedStatBoost(null, false, perc(percSD, -deltaR)); - changes.setStatChanges(Stream.concat( + changes.setStatChanges(Stream.of( Stream.of(hitpoints.effect(client)), - Stream.concat( Stream.of(defence.effect(client)), Stream.of(saradominBrewStats) .filter(stat -> 1 < stat.getValue(client)) @@ -67,12 +66,13 @@ public class SaradominBrew implements Effect { calc.setStat(stat); return calc.effect(client); - }) - ) - ).toArray(StatChange[]::new)); + })) + .reduce(Stream::concat) + .orElseGet(Stream::empty) + .toArray(StatChange[]::new)); changes.setPositivity(Stream.of(changes.getStatChanges()) - .map(sc -> sc.getPositivity()) + .map(StatChange::getPositivity) .max(Comparator.naturalOrder()).get()); return changes; } -} \ No newline at end of file +}