From b9191114fad467d3c62fe25623bd29112ae35f7f Mon Sep 17 00:00:00 2001 From: Adam Date: Tue, 26 Oct 2021 21:43:10 -0400 Subject: [PATCH] skillcalc: only recompute xp bonus values once when bonus changes --- .../plugins/skillcalculator/SkillCalculator.java | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/runelite-client/src/main/java/net/runelite/client/plugins/skillcalculator/SkillCalculator.java b/runelite-client/src/main/java/net/runelite/client/plugins/skillcalculator/SkillCalculator.java index 8d9581adde..f23a14d703 100644 --- a/runelite-client/src/main/java/net/runelite/client/plugins/skillcalculator/SkillCalculator.java +++ b/runelite-client/src/main/java/net/runelite/client/plugins/skillcalculator/SkillCalculator.java @@ -272,19 +272,15 @@ class SkillCalculator extends JPanel private void adjustCheckboxes(JCheckBox target, SkillBonus bonus) { - adjustXPBonus(0); - bonusCheckBoxes.forEach(otherSelectedCheckbox -> + for (JCheckBox otherSelectedCheckbox : bonusCheckBoxes) { if (otherSelectedCheckbox != target) { otherSelectedCheckbox.setSelected(false); } - }); - - if (target.isSelected()) - { - adjustXPBonus(bonus.getValue()); } + + adjustXPBonus(target.isSelected() ? bonus.getValue() : 0f); } private void renderActionSlots()