ra/runelite
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

Merge pull request #8509 from deathbeam/fix-because-people-ignore-me

Browse Source 
Cleanup clue scroll plugin (fix access levels and properly use Lombok)
This commit is contained in:
Tomas Slusny
2019-04-14 16:17:18 +02:00
committed by GitHub
parent b0f41f1818 ea857fa2ec
commit b63fd88e29
3 changed files with 5 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
runelite-client/src/main/java/net/runelite/client/plugins/cluescrolls/ClueScrollOverlay.java
View File

@@ -53,7 +53,7 @@ public class ClueScrollOverlay extends Overlay
private final PanelComponent panelComponent = new PanelComponent(); private final PanelComponent panelComponent = new PanelComponent();
@Inject @Inject
public ClueScrollOverlay(ClueScrollPlugin plugin) private ClueScrollOverlay(ClueScrollPlugin plugin)
{ {
super(plugin); super(plugin);
this.plugin = plugin; this.plugin = plugin;

2
runelite-client/src/main/java/net/runelite/client/plugins/cluescrolls/ClueScrollWorldOverlay.java
View File

@@ -44,7 +44,7 @@ public class ClueScrollWorldOverlay extends Overlay
private final ClueScrollPlugin plugin; private final ClueScrollPlugin plugin;
@Inject @Inject
public ClueScrollWorldOverlay(ClueScrollPlugin plugin) private ClueScrollWorldOverlay(ClueScrollPlugin plugin)
{ {
setPosition(OverlayPosition.DYNAMIC); setPosition(OverlayPosition.DYNAMIC);
setLayer(OverlayLayer.ABOVE_SCENE); setLayer(OverlayLayer.ABOVE_SCENE);

8
runelite-client/src/main/java/net/runelite/client/plugins/cluescrolls/clues/MusicClue.java
View File

@@ -28,6 +28,8 @@ import java.awt.Color;
import java.awt.Graphics2D; import java.awt.Graphics2D;
import java.util.regex.Matcher; import java.util.regex.Matcher;
import java.util.regex.Pattern; import java.util.regex.Pattern;
import lombok.AccessLevel;
import lombok.AllArgsConstructor;
import lombok.Getter; import lombok.Getter;
import net.runelite.api.NPC; import net.runelite.api.NPC;
import net.runelite.api.coords.WorldPoint; import net.runelite.api.coords.WorldPoint;
@@ -39,6 +41,7 @@ import net.runelite.client.ui.overlay.components.LineComponent;
import net.runelite.client.ui.overlay.components.PanelComponent; import net.runelite.client.ui.overlay.components.PanelComponent;
import net.runelite.client.ui.overlay.components.TitleComponent; import net.runelite.client.ui.overlay.components.TitleComponent;
@AllArgsConstructor(access = AccessLevel.PRIVATE)
@Getter @Getter
public class MusicClue extends ClueScroll implements NpcClueScroll public class MusicClue extends ClueScroll implements NpcClueScroll
{ {
@@ -48,11 +51,6 @@ public class MusicClue extends ClueScroll implements NpcClueScroll
private final String song; private final String song;
private MusicClue(String song)
{
this.song = song;
}
@Override @Override
public void makeOverlayHint(PanelComponent panelComponent, ClueScrollPlugin plugin) public void makeOverlayHint(PanelComponent panelComponent, ClueScrollPlugin plugin)
{ {