ra/runelite
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

itemstats: remove quest field

Browse Source 
this has always been unused and isn't particularly useful to us anyway
This commit is contained in:
Max Weber
2021-08-06 00:19:12 -06:00
parent 0a86fe35af
commit b23a310832
4 changed files with 7 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
http-api/src/main/java/net/runelite/http/api/item/ItemStats.java
View File

@@ -30,7 +30,6 @@ import lombok.Value;
@Value @Value
public class ItemStats public class ItemStats
{ {
private boolean quest;
private boolean equipable; private boolean equipable;
private double weight; private double weight;
@SerializedName("ge_limit") @SerializedName("ge_limit")
@@ -79,7 +78,7 @@ public class ItemStats
newEquipment = equipment; newEquipment = equipment;
} }
return new ItemStats(quest, equipable, newWeight, 0, newEquipment); return new ItemStats(equipable, newWeight, 0, newEquipment);
} }
} }

2
runelite-client/src/main/java/net/runelite/client/plugins/itemstats/ItemStatOverlay.java
View File

@@ -55,7 +55,7 @@ public class ItemStatOverlay extends Overlay
{ {
// Unarmed attack speed is 4 // Unarmed attack speed is 4
@VisibleForTesting @VisibleForTesting
static final ItemStats UNARMED = new ItemStats(false, true, 0, 0, static final ItemStats UNARMED = new ItemStats(true, 0, 0,
ItemEquipmentStats.builder() ItemEquipmentStats.builder()
.aspeed(4) .aspeed(4)
.build()); .build());

8
runelite-client/src/test/java/net/runelite/client/plugins/itemstats/ItemStatOverlayTest.java
View File

@@ -53,7 +53,7 @@ import org.mockito.junit.MockitoJUnitRunner;
public class ItemStatOverlayTest public class ItemStatOverlayTest
{ {
// Weapon definitions // Weapon definitions
private static final ItemStats ABYSSAL_DAGGER = new ItemStats(false, true, 0.453, 8, private static final ItemStats ABYSSAL_DAGGER = new ItemStats(true, 0.453, 8,
ItemEquipmentStats.builder() ItemEquipmentStats.builder()
.slot(EquipmentInventorySlot.WEAPON.getSlotIdx()) .slot(EquipmentInventorySlot.WEAPON.getSlotIdx())
.isTwoHanded(false) .isTwoHanded(false)
@@ -65,7 +65,7 @@ public class ItemStatOverlayTest
.str(75) .str(75)
.aspeed(4) .aspeed(4)
.build()); .build());
private static final ItemStats KATANA = new ItemStats(false, true, 0, 8, private static final ItemStats KATANA = new ItemStats(true, 0, 8,
ItemEquipmentStats.builder() ItemEquipmentStats.builder()
.slot(EquipmentInventorySlot.WEAPON.getSlotIdx()) .slot(EquipmentInventorySlot.WEAPON.getSlotIdx())
.isTwoHanded(true) .isTwoHanded(true)
@@ -78,7 +78,7 @@ public class ItemStatOverlayTest
.str(40) .str(40)
.aspeed(4) .aspeed(4)
.build()); .build());
private static final ItemStats BLOWPIPE = new ItemStats(false, true, 0, 0, private static final ItemStats BLOWPIPE = new ItemStats(true, 0, 0,
ItemEquipmentStats.builder() ItemEquipmentStats.builder()
.slot(EquipmentInventorySlot.WEAPON.getSlotIdx()) .slot(EquipmentInventorySlot.WEAPON.getSlotIdx())
.isTwoHanded(true) .isTwoHanded(true)
@@ -86,7 +86,7 @@ public class ItemStatOverlayTest
.rstr(40) .rstr(40)
.aspeed(3) .aspeed(3)
.build()); .build());
private static final ItemStats HEAVY_BALLISTA = new ItemStats(false, true, 4, 8, private static final ItemStats HEAVY_BALLISTA = new ItemStats(true, 4, 8,
ItemEquipmentStats.builder() ItemEquipmentStats.builder()
.slot(EquipmentInventorySlot.WEAPON.getSlotIdx()) .slot(EquipmentInventorySlot.WEAPON.getSlotIdx())
.isTwoHanded(true) .isTwoHanded(true)

2
runelite-client/src/test/java/net/runelite/client/plugins/prayer/PrayerPluginTest.java
View File

@@ -55,7 +55,7 @@ import org.mockito.junit.MockitoJUnitRunner;
@RunWith(MockitoJUnitRunner.class) @RunWith(MockitoJUnitRunner.class)
public class PrayerPluginTest public class PrayerPluginTest
{ {
private static final ItemStats HIGH_PRAYER_BONUS_WEAPON = new ItemStats(false, false, 0, 0, private static final ItemStats HIGH_PRAYER_BONUS_WEAPON = new ItemStats(false, 0, 0,
ItemEquipmentStats.builder() ItemEquipmentStats.builder()
.slot(EquipmentInventorySlot.WEAPON.getSlotIdx()) .slot(EquipmentInventorySlot.WEAPON.getSlotIdx())
.prayer(50) .prayer(50)