From ac30c8dc3f1d5d4de152bf2e61e6f953d3fb6265 Mon Sep 17 00:00:00 2001 From: Adam Date: Wed, 1 Jul 2020 11:32:46 -0400 Subject: [PATCH] npc indicators: fix tag/untag option name selection logic When pressed tag/untag will first check if the npc id is tagged via npcTags, so the menu option should be based off of that, and not whether or not the npc is highlighted generally --- .../client/plugins/npchighlight/NpcIndicatorsPlugin.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/runelite-client/src/main/java/net/runelite/client/plugins/npchighlight/NpcIndicatorsPlugin.java b/runelite-client/src/main/java/net/runelite/client/plugins/npchighlight/NpcIndicatorsPlugin.java index 780375dcdf..0990ff39a7 100644 --- a/runelite-client/src/main/java/net/runelite/client/plugins/npchighlight/NpcIndicatorsPlugin.java +++ b/runelite-client/src/main/java/net/runelite/client/plugins/npchighlight/NpcIndicatorsPlugin.java @@ -308,7 +308,7 @@ public class NpcIndicatorsPlugin extends Plugin } final MenuEntry tagEntry = menuEntries[menuEntries.length - 1] = new MenuEntry(); - tagEntry.setOption(highlightedNpcs.contains(npc) ? UNTAG : TAG); + tagEntry.setOption(npcTags.contains(npc.getIndex()) ? UNTAG : TAG); tagEntry.setTarget(event.getTarget()); tagEntry.setParam0(event.getActionParam0()); tagEntry.setParam1(event.getActionParam1());