From e5ebd5a0513f771537a42041bf395bd71a10936d Mon Sep 17 00:00:00 2001 From: trimbe Date: Tue, 6 Aug 2019 21:46:56 -0400 Subject: [PATCH 1/3] api: remove devtools annotation and rename setSetting --- runelite-api/src/main/java/net/runelite/api/Client.java | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/runelite-api/src/main/java/net/runelite/api/Client.java b/runelite-api/src/main/java/net/runelite/api/Client.java index 95cf40931a..ddb29e98b0 100644 --- a/runelite-api/src/main/java/net/runelite/api/Client.java +++ b/runelite-api/src/main/java/net/runelite/api/Client.java @@ -690,8 +690,7 @@ public interface Client extends GameEngine * @param varbit the variable * @param value the new value */ - @VisibleForDevtools - void setSetting(Varbits varbit, int value); + void setVarbit(Varbits varbit, int value); /** * Gets the value of a given variable. From 4be0fc0e38566ddfc6b0739c83e892ecb8707e42 Mon Sep 17 00:00:00 2001 From: trimbe Date: Tue, 6 Aug 2019 21:47:29 -0400 Subject: [PATCH 2/3] bank tags: use setVarbit instead of setVarbitValue --- .../net/runelite/client/plugins/banktags/tabs/TabInterface.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/runelite-client/src/main/java/net/runelite/client/plugins/banktags/tabs/TabInterface.java b/runelite-client/src/main/java/net/runelite/client/plugins/banktags/tabs/TabInterface.java index 14b6ee9178..21aeba6645 100644 --- a/runelite-client/src/main/java/net/runelite/client/plugins/banktags/tabs/TabInterface.java +++ b/runelite-client/src/main/java/net/runelite/client/plugins/banktags/tabs/TabInterface.java @@ -327,7 +327,7 @@ public class TabInterface switch (event.getOp()) { case Tab.OPEN_TAG: - client.setVarbitValue(client.getVarps(), Varbits.CURRENT_BANK_TAB.getId(), 0); + client.setVarbit(Varbits.CURRENT_BANK_TAB, 0); Widget clicked = event.getSource(); TagTab tab = tabManager.find(Text.removeTags(clicked.getName())); From a0aac8797130848b2e4491171624c3f06394a013 Mon Sep 17 00:00:00 2001 From: trimbe Date: Tue, 6 Aug 2019 21:48:18 -0400 Subject: [PATCH 3/3] bank tags: properly open saved tab Jagex appears to be syncing the current tab varbit more aggressively now, so if the active tab was not the first tab before switching to a tag tab, bank layout would misbehave when the bank was reopened. --- .../net/runelite/client/plugins/banktags/tabs/TabInterface.java | 2 ++ 1 file changed, 2 insertions(+) diff --git a/runelite-client/src/main/java/net/runelite/client/plugins/banktags/tabs/TabInterface.java b/runelite-client/src/main/java/net/runelite/client/plugins/banktags/tabs/TabInterface.java index 21aeba6645..19baa9041c 100644 --- a/runelite-client/src/main/java/net/runelite/client/plugins/banktags/tabs/TabInterface.java +++ b/runelite-client/src/main/java/net/runelite/client/plugins/banktags/tabs/TabInterface.java @@ -215,6 +215,8 @@ public class TabInterface if (config.rememberTab() && !Strings.isNullOrEmpty(config.tab())) { + // the server will resync the last opened vanilla tab when the bank is opened + client.setVarbit(Varbits.CURRENT_BANK_TAB, 0); openTag(config.tab()); } }