Replace opcode constants with ScriptOpcodes field refs in rsclient

runescape-client/src/main/java/Varcs.java

@@ -261,7 +261,6 @@ public class Varcs {
    void read() {
       AccessFile var1 = this.getPreferencesFile(false);
 
-      label225: {
          try {
             byte[] var2 = new byte[(int)var1.length()];
 
@@ -279,20 +278,18 @@ public class Varcs {
             }
 
             int var5 = var25.readUnsignedByte();
-            if (var5 >= 0 && var5 <= 2) {
+         if (var5 < 0 || var5 > 2) {
+            return;
+         }
+
                int var6;
                int var7;
                int var8;
                int var9;
                if (var5 >= 2) {
                   var9 = var25.readUnsignedShort();
-                  var6 = 0;
-
-                  while (true) {
-                     if (var6 >= var9) {
-                        break label225;
-                     }
 
+            for (var6 = 0; var6 < var9; ++var6) {
                      var7 = var25.readUnsignedShort();
                      var8 = var25.readUnsignedByte();
                      class3 var10 = (class3)ScriptFrame.findEnumerated(class3.method34(), var8);
@@ -300,8 +297,6 @@ public class Varcs {
                      if (this.intsPersistence[var7]) {
                         this.map.put(var7, var11);
                      }
-
-                     ++var6;
                   }
                } else {
                   var9 = var25.readUnsignedShort();
@@ -315,21 +310,13 @@ public class Varcs {
                   }
 
                   var6 = var25.readUnsignedShort();
-                  var7 = 0;
-
-                  while (true) {
-                     if (var7 >= var6) {
-                        break label225;
-                     }
 
+            for (var7 = 0; var7 < var6; ++var7) {
                      var25.readUnsignedShort();
                      var25.readStringCp1252NullTerminated();
-                     ++var7;
-                  }
                }
             }
          } catch (Exception var23) {
-            break label225;
          } finally {
             try {
                var1.close();
@@ -338,9 +325,6 @@ public class Varcs {
 
          }
 
-         return;
-      }
-
       this.unwrittenChanges = false;
    }