ra/runelite
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

Fix bank value overflow

Browse Source 
Use longs instead of ints for per-item price calculations to avoid int
overflows.

Fixes: #1460
This commit is contained in:
Adam
2018-04-15 19:48:22 -04:00
parent 10e7d6bb9c
commit a7d1c8815c
2 changed files with 110 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
runelite-client/src/main/java/net/runelite/client/plugins/bankvalue/BankCalculation.java
View File

@@ -108,12 +108,12 @@ class BankCalculation
if (widgetItem.getId() == PLATINUM_TOKEN)
{
gePrice += widgetItem.getQuantity() * 1000;
haPrice += widgetItem.getQuantity() * 1000;
gePrice += widgetItem.getQuantity() * 1000L;
haPrice += widgetItem.getQuantity() * 1000L;
continue;
}
ItemComposition itemComposition = itemManager.getItemComposition(widgetItem.getId());
final ItemComposition itemComposition = itemManager.getItemComposition(widgetItem.getId());
itemCompositions.add(itemComposition);
itemMap.put(widgetItem.getId(), widgetItem);
@@ -152,7 +152,7 @@ class BankCalculation
continue; // cached no price
}
gePrice += itemPrice.getPrice() * itemMap.get(itemPrice.getItem().getId()).getQuantity();
gePrice += (long) itemPrice.getPrice() * (long) itemMap.get(itemPrice.getItem().getId()).getQuantity();
}
}
catch (Exception ex2)
@@ -178,8 +178,8 @@ class BankCalculation
if (price > 0)
{
haPrice += Math.round(price * HIGH_ALCHEMY_CONSTANT) *
itemMap.get(itemComposition.getId()).getQuantity();
haPrice += (long) Math.round(price * HIGH_ALCHEMY_CONSTANT) *
(long) itemMap.get(itemComposition.getId()).getQuantity();
}
}
}