ra/runelite
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

Merge pull request #2660 from open-osrs/configmanager-log-null-defaults-without-crashing

Browse Source 
configmanager: log null defaults without crashing
This commit is contained in:
ThatGamerBlue
2020-06-04 02:01:18 +01:00
committed by GitHub
parent 94714f3cb6 6a1f9927e6
commit a3bdca6df7
1 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
runelite-client/src/main/java/net/runelite/client/config/ConfigManager.java
View File

@@ -753,6 +753,11 @@ public class ConfigManager
} }
String current = getConfiguration(group.value(), item.keyName()); String current = getConfiguration(group.value(), item.keyName());
if (defaultValue == null)
{
log.error("Plugin with bad default configuration, see config group {}, keyName {}", group.value(), item.keyName());
continue;
}
String valueString = objectToString(defaultValue); String valueString = objectToString(defaultValue);
// null and the empty string are treated identically in sendConfig and treated as an unset // null and the empty string are treated identically in sendConfig and treated as an unset
// If a config value defaults to "" and the current value is null, it will cause an extra // If a config value defaults to "" and the current value is null, it will cause an extra
@@ -884,4 +889,4 @@ public class ConfigManager
{ {
return consumers.getOrDefault(configGroup + "." + keyName, (p) -> log.error("Failed to retrieve consumer with name {}.{}", configGroup, keyName)); return consumers.getOrDefault(configGroup + "." + keyName, (p) -> log.error("Failed to retrieve consumer with name {}.{}", configGroup, keyName));
} }
} }