diff --git a/runelite-client/src/main/java/net/runelite/client/discord/DiscordPresence.java b/runelite-client/src/main/java/net/runelite/client/discord/DiscordPresence.java index fd444e8929..66bb52fb5d 100644 --- a/runelite-client/src/main/java/net/runelite/client/discord/DiscordPresence.java +++ b/runelite-client/src/main/java/net/runelite/client/discord/DiscordPresence.java @@ -31,7 +31,7 @@ import lombok.Value; /** * Represents Discord Rich Presence RPC data */ -@Builder +@Builder(toBuilder = true) @Value public class DiscordPresence { diff --git a/runelite-client/src/main/java/net/runelite/client/plugins/discord/DiscordState.java b/runelite-client/src/main/java/net/runelite/client/plugins/discord/DiscordState.java index 3361b26c52..6950200606 100644 --- a/runelite-client/src/main/java/net/runelite/client/plugins/discord/DiscordState.java +++ b/runelite-client/src/main/java/net/runelite/client/plugins/discord/DiscordState.java @@ -122,9 +122,7 @@ class DiscordState } else { - // If we aren't showing the elapsed time within Discord then - // We null out the event start property - event = new EventWithTime(eventType, config.hideElapsedTime() ? null : Instant.now()); + event = new EventWithTime(eventType, Instant.now()); events.add(event); } @@ -177,7 +175,7 @@ class DiscordState .state(MoreObjects.firstNonNull(state, "")) .details(MoreObjects.firstNonNull(details, "")) .largeImageText(RuneLiteProperties.getTitle() + " v" + versionShortHand) - .startTimestamp(event.getStart()) + .startTimestamp(config.hideElapsedTime() ? null : event.getStart()) .smallImageKey(imageKey) .partyMax(PARTY_MAX) .partySize(party.getMembers().size()); @@ -203,8 +201,25 @@ class DiscordState */ void checkForTimeout() { + if (events.isEmpty()) + { + return; + } + final Duration actionTimeout = Duration.ofMinutes(config.actionTimeout()); final Instant now = Instant.now(); + final EventWithTime eventWithTime = events.get(0); + events.removeIf(event -> event.getType().isShouldTimeout() && now.isAfter(event.getUpdated().plus(actionTimeout))); + + if (eventWithTime.getType().getState().equals(DiscordGameEventType.IN_MENU.getState()) && now.isAfter(eventWithTime.getStart().plus(actionTimeout))) + { + final DiscordPresence presence = lastPresence + .toBuilder() + .startTimestamp(null) + .build(); + lastPresence = presence; + discordService.updatePresence(presence); + } } } diff --git a/runelite-client/src/test/java/net/runelite/client/plugins/discord/DiscordStateTest.java b/runelite-client/src/test/java/net/runelite/client/plugins/discord/DiscordStateTest.java new file mode 100644 index 0000000000..9cfcb1fbbb --- /dev/null +++ b/runelite-client/src/test/java/net/runelite/client/plugins/discord/DiscordStateTest.java @@ -0,0 +1,91 @@ +/* + * Copyright (c) 2018, Adam + * All rights reserved. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions are met: + * + * 1. Redistributions of source code must retain the above copyright notice, this + * list of conditions and the following disclaimer. + * 2. Redistributions in binary form must reproduce the above copyright notice, + * this list of conditions and the following disclaimer in the documentation + * and/or other materials provided with the distribution. + * + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND + * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED + * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE + * DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR + * ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES + * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; + * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND + * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS + * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + */ +package net.runelite.client.plugins.discord; + +import com.google.inject.Guice; +import com.google.inject.testing.fieldbinder.Bind; +import com.google.inject.testing.fieldbinder.BoundFieldModule; +import java.util.List; +import javax.inject.Inject; +import net.runelite.api.Client; +import net.runelite.client.discord.DiscordPresence; +import net.runelite.client.discord.DiscordService; +import net.runelite.client.ws.PartyService; +import static org.junit.Assert.assertNull; +import org.junit.Before; +import org.junit.Test; +import org.junit.runner.RunWith; +import org.mockito.ArgumentCaptor; +import static org.mockito.ArgumentMatchers.any; +import org.mockito.Mock; +import static org.mockito.Mockito.times; +import static org.mockito.Mockito.verify; +import static org.mockito.Mockito.when; +import org.mockito.junit.MockitoJUnitRunner; + +@RunWith(MockitoJUnitRunner.class) +public class DiscordStateTest +{ + @Inject + DiscordState discordState; + + @Mock + @Bind + DiscordConfig discordConfig; + + @Mock + @Bind + DiscordService discordService; + + @Mock + @Bind + Client client; + + @Mock + @Bind + PartyService partyService; + + @Before + public void before() + { + Guice.createInjector(BoundFieldModule.of(this)).injectMembers(this); + } + + @Test + public void testStatusTimeout() + { + when(discordConfig.actionTimeout()).thenReturn(0); + when(discordConfig.hideElapsedTime()).thenReturn(false); + + discordState.triggerEvent(DiscordGameEventType.IN_MENU); + verify(discordService).updatePresence(any(DiscordPresence.class)); + + discordState.checkForTimeout(); + ArgumentCaptor captor = ArgumentCaptor.forClass(DiscordPresence.class); + verify(discordService, times(2)).updatePresence(captor.capture()); + List captured = captor.getAllValues(); + assertNull(captured.get(captured.size() - 1).getEndTimestamp()); + } +}