From 9997a03d76d39087fa104cabfc6504880691136d Mon Sep 17 00:00:00 2001 From: Andrew Fulton Date: Mon, 11 Feb 2019 17:52:33 -0600 Subject: [PATCH] Always return null for RUNELITE_OVERLAY's --- .../mousehighlight/MouseHighlightOverlay.java | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/runelite-client/src/main/java/net/runelite/client/plugins/mousehighlight/MouseHighlightOverlay.java b/runelite-client/src/main/java/net/runelite/client/plugins/mousehighlight/MouseHighlightOverlay.java index 80e9c969af..eeb48c5642 100644 --- a/runelite-client/src/main/java/net/runelite/client/plugins/mousehighlight/MouseHighlightOverlay.java +++ b/runelite-client/src/main/java/net/runelite/client/plugins/mousehighlight/MouseHighlightOverlay.java @@ -75,9 +75,8 @@ class MouseHighlightOverlay extends Overlay String option = menuEntry.getOption(); int type = menuEntry.getType(); - if (!config.isRightClickTooltipEnabled() && isMenuActionRightClickOnly(type)) + if (shouldNotRenderMenuAction(type)) { - // These are always right click only return null; } @@ -137,9 +136,14 @@ class MouseHighlightOverlay extends Overlay return null; } - private boolean isMenuActionRightClickOnly(int type) + private boolean shouldNotRenderMenuAction(int type) { return type == MenuAction.RUNELITE_OVERLAY.getId() - || type == MenuAction.EXAMINE_ITEM_BANK_EQ.getId(); + || (!config.isRightClickTooltipEnabled() && isMenuActionRightClickOnly(type)); + } + + private boolean isMenuActionRightClickOnly(int type) + { + return type == MenuAction.EXAMINE_ITEM_BANK_EQ.getId(); } }