From 9506c672a0612dc7b33cb2fd78b9e265173973ba Mon Sep 17 00:00:00 2001 From: CC007 Date: Sun, 2 Sep 2018 09:54:15 +0200 Subject: [PATCH] Fix locale not being applied for StackFormatterTest (#5216) Failed tests before the commit: ``` Failed tests: StackFormatterTest.quantityToRSDecimalStackSize:49 expected:<21[.]7K> but was:<21[,]7K> StackFormatterTest.quantityToStackSize:84 expected:<1[,]000> but was:<1[.]000> StackFormatterTest.stackSizeToQuantity:107 expected:<10500> but was:<10> ``` After the commit, the tests succeeded. --- .../java/net/runelite/client/util/StackFormatter.java | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/runelite-client/src/main/java/net/runelite/client/util/StackFormatter.java b/runelite-client/src/main/java/net/runelite/client/util/StackFormatter.java index 433951887d..40dda01a4e 100644 --- a/runelite-client/src/main/java/net/runelite/client/util/StackFormatter.java +++ b/runelite-client/src/main/java/net/runelite/client/util/StackFormatter.java @@ -25,8 +25,10 @@ package net.runelite.client.util; import java.text.DecimalFormat; +import java.text.DecimalFormatSymbols; import java.text.NumberFormat; import java.text.ParseException; +import java.util.Locale; import java.util.regex.Matcher; import java.util.regex.Pattern; @@ -49,12 +51,15 @@ public class StackFormatter /** * A number formatter */ - private static final NumberFormat NUMBER_FORMATTER = NumberFormat.getInstance(); + private static final NumberFormat NUMBER_FORMATTER = NumberFormat.getInstance(Locale.ENGLISH); /** * A decimal number formatter */ - private static final NumberFormat DECIMAL_FORMATTER = new DecimalFormat("#,###.#"); + private static final NumberFormat DECIMAL_FORMATTER = new DecimalFormat( + "#,###.#", + DecimalFormatSymbols.getInstance(Locale.ENGLISH) + ); /** * Convert a quantity to a nicely formatted stack size.