ra/runelite
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

pvptools: Merge nested if statements

Browse Source
This commit is contained in:
sdburns1998
2019-07-07 18:03:01 +02:00
parent 85264649db
commit 8ff950ff3d
3 changed files with 39 additions and 61 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
runelite-client/src/main/java/net/runelite/client/plugins/pvptools/PlayerCountOverlay.java
View File

@@ -52,11 +52,10 @@ public class PlayerCountOverlay extends Overlay
@Override @Override
public Dimension render(Graphics2D graphics) public Dimension render(Graphics2D graphics)
{ {
if (pvpToolsPlugin.isCountPlayers()) if (pvpToolsPlugin.isCountPlayers() &&
{ (client.getVar(Varbits.IN_WILDERNESS) == 1 || WorldType.isPvpWorld(client.getWorldType())
if ((client.getVar(Varbits.IN_WILDERNESS) == 1) || WorldType.isPvpWorld(client.getWorldType())
|| ArrayUtils.contains(CLAN_WARS_REGIONS, client.getMapRegions()[0]) || || ArrayUtils.contains(CLAN_WARS_REGIONS, client.getMapRegions()[0]) ||
WorldType.isDeadmanWorld(client.getWorldType())) WorldType.isDeadmanWorld(client.getWorldType())))
{ {
// Make this stop showing up when its not relevant // Make this stop showing up when its not relevant
TableComponent tableComponent = new TableComponent(); TableComponent tableComponent = new TableComponent();
@@ -71,7 +70,6 @@ public class PlayerCountOverlay extends Overlay
tableComponent.addRows(firstRow, secondRow); tableComponent.addRows(firstRow, secondRow);
return tableComponent.render(graphics); return tableComponent.render(graphics);
} }
}
return null; return null;
} }
} }

5
runelite-client/src/main/java/net/runelite/client/plugins/pvptools/PvpToolsOverlay.java
View File

@@ -40,14 +40,11 @@ public class PvpToolsOverlay extends Overlay
@Override @Override
public Dimension render(Graphics2D graphics) public Dimension render(Graphics2D graphics)
{ {
if (pvpToolsPlugin.isFallInHelper()) if (pvpToolsPlugin.isFallInHelper() && pvpToolsPlugin.fallinHelperEnabled)
{
if (pvpToolsPlugin.fallinHelperEnabled)
{ {
graphics.setFont(FontManager.getRunescapeFont().deriveFont(28)); graphics.setFont(FontManager.getRunescapeFont().deriveFont(28));
OverlayUtil.renderTextLocation(graphics, new Point(200, 80), "FALL IN HELPER ENABLED", Color.YELLOW); OverlayUtil.renderTextLocation(graphics, new Point(200, 80), "FALL IN HELPER ENABLED", Color.YELLOW);
} }
}
return null; return null;
} }
} }

29
runelite-client/src/main/java/net/runelite/client/plugins/pvptools/PvpToolsPlugin.java
View File

@@ -195,15 +195,12 @@ public class PvpToolsPlugin extends Plugin
if (!Objects.isNull(clanMember)) if (!Objects.isNull(clanMember))
{ {
List<String> arrayList = ccMembers.stream().map(player -> Text.removeTags(Text.standardize(player.getName()))).collect(Collectors.toList()); List<String> arrayList = ccMembers.stream().map(player -> Text.removeTags(Text.standardize(player.getName()))).collect(Collectors.toList());
if (!arrayList.contains(Text.removeTags(Text.standardize(clanMember.getUsername())))) if (!arrayList.contains(Text.removeTags(Text.standardize(clanMember.getUsername()))) && !missingMembers.contains(clanMember.getUsername()))
{
if (!missingMembers.contains(clanMember.getUsername()))
{ {
missingMembers.add("[W" + clanMember.getWorld() + "] - " + clanMember.getUsername()); missingMembers.add("[W" + clanMember.getWorld() + "] - " + clanMember.getUsername());
} }
} }
} }
}
return missingMembers; return missingMembers;
} }
@@ -217,15 +214,12 @@ public class PvpToolsPlugin extends Plugin
if (!Objects.isNull(clanMember)) if (!Objects.isNull(clanMember))
{ {
List<String> arrayList = ccMembers.stream().map(player -> Text.removeTags(Text.standardize(player.getName()))).collect(Collectors.toList()); List<String> arrayList = ccMembers.stream().map(player -> Text.removeTags(Text.standardize(player.getName()))).collect(Collectors.toList());
if (arrayList.contains(Text.removeTags(Text.standardize(clanMember.getUsername())))) if (arrayList.contains(Text.removeTags(Text.standardize(clanMember.getUsername()))) && !currentMembers.contains(clanMember.getUsername()))
{
if (!currentMembers.contains(clanMember.getUsername()))
{ {
currentMembers.add(clanMember.getUsername()); currentMembers.add(clanMember.getUsername());
} }
} }
} }
}
return currentMembers; return currentMembers;
} }
@@ -370,14 +364,11 @@ public class PvpToolsPlugin extends Plugin
{ {
getCarriedWealth(); getCarriedWealth();
} }
if (event.getGameState().equals(GameState.LOGGED_IN)) if (event.getGameState().equals(GameState.LOGGED_IN) && this.countPlayers)
{
if (this.countPlayers)
{ {
updatePlayers(); updatePlayers();
} }
} }
}
@Subscribe @Subscribe
public void onPlayerSpawned(PlayerSpawned event) public void onPlayerSpawned(PlayerSpawned event)
@@ -478,11 +469,8 @@ public class PvpToolsPlugin extends Plugin
overheadCount = new int[]{0, 0, 0}; overheadCount = new int[]{0, 0, 0};
for (Player p : client.getPlayers()) for (Player p : client.getPlayers())
{ {
if (Objects.nonNull(p)) if (Objects.nonNull(p) && PvPUtil.isAttackable(client, p) &&
{ !p.isClanMember() && !(p.getOverheadIcon() == null))
if (PvPUtil.isAttackable(client, p))
{
if (!p.isClanMember() && !(p.getOverheadIcon() == null))
{ {
switch (p.getOverheadIcon()) switch (p.getOverheadIcon())
{ {
@@ -498,8 +486,6 @@ public class PvpToolsPlugin extends Plugin
} }
} }
} }
}
}
updatePrayerNumbers(); updatePrayerNumbers();
} }
@@ -548,13 +534,10 @@ public class PvpToolsPlugin extends Plugin
panel.totalRiskLabel.repaint(); panel.totalRiskLabel.repaint();
int itemLimit = 0; int itemLimit = 0;
if (client.getLocalPlayer().getSkullIcon() != null) if (client.getLocalPlayer().getSkullIcon() != null && client.getLocalPlayer().getSkullIcon() == SkullIcon.SKULL)
{
if (client.getLocalPlayer().getSkullIcon() == SkullIcon.SKULL)
{ {
itemLimit = 1; itemLimit = 1;
} }
}
if (client.getLocalPlayer().getSkullIcon() == null) if (client.getLocalPlayer().getSkullIcon() == null)
{ {
itemLimit = 4; itemLimit = 4;