From 11ebb3a599a1514df8aed3ff77f7a5eaff745a6d Mon Sep 17 00:00:00 2001 From: raiyni Date: Wed, 10 Oct 2018 11:51:17 -0500 Subject: [PATCH 1/3] Don't update tags if interface is force closed --- .../net/runelite/client/plugins/banktags/BankTagsPlugin.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/runelite-client/src/main/java/net/runelite/client/plugins/banktags/BankTagsPlugin.java b/runelite-client/src/main/java/net/runelite/client/plugins/banktags/BankTagsPlugin.java index 3d46f59527..fdb2447653 100644 --- a/runelite-client/src/main/java/net/runelite/client/plugins/banktags/BankTagsPlugin.java +++ b/runelite-client/src/main/java/net/runelite/client/plugins/banktags/BankTagsPlugin.java @@ -32,6 +32,7 @@ import com.google.common.eventbus.Subscribe; import com.google.inject.Provides; import java.awt.event.MouseWheelEvent; import java.util.Arrays; +import java.util.Objects; import javax.inject.Inject; import net.runelite.api.Client; import net.runelite.api.InventoryID; @@ -40,6 +41,7 @@ import net.runelite.api.ItemComposition; import net.runelite.api.ItemContainer; import net.runelite.api.MenuAction; import net.runelite.api.MenuEntry; +import net.runelite.api.VarClientStr; import net.runelite.api.events.ConfigChanged; import net.runelite.api.events.DraggingWidgetChanged; import net.runelite.api.events.GameTick; @@ -248,7 +250,7 @@ public class BankTagsPlugin extends Plugin implements MouseWheelListener chatboxInputManager.openInputWindow(itemName + " tags:", initialValue, (newTags) -> { - if (newTags == null) + if (!Objects.equals(newTags, client.getVar(VarClientStr.INPUT_TEXT))) { return; } From cc664360dd9a1d7e2cf2454915705913dd8bee40 Mon Sep 17 00:00:00 2001 From: raiyni Date: Wed, 10 Oct 2018 15:02:21 -0500 Subject: [PATCH 2/3] Don't change the active tab if tags are being edited --- .../client/plugins/banktags/tabs/TabInterface.java | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/runelite-client/src/main/java/net/runelite/client/plugins/banktags/tabs/TabInterface.java b/runelite-client/src/main/java/net/runelite/client/plugins/banktags/tabs/TabInterface.java index bb88a1b00f..4ff70f6ad5 100644 --- a/runelite-client/src/main/java/net/runelite/client/plugins/banktags/tabs/TabInterface.java +++ b/runelite-client/src/main/java/net/runelite/client/plugins/banktags/tabs/TabInterface.java @@ -224,6 +224,14 @@ public class TabInterface return; } + if (activeTab != null && client.getVar(VarClientInt.INPUT_TYPE) == InputType.RUNELITE.getType()) + { + // don't reset active tab if we are editing tags + updateBounds(); + scrollTab(0); + return; + } + String str = client.getVar(VarClientStr.INPUT_TEXT); if (Strings.isNullOrEmpty(str)) From 593cd23394d691d3b2a4e9b6c4d450ea597f72b0 Mon Sep 17 00:00:00 2001 From: raiyni Date: Wed, 10 Oct 2018 15:06:24 -0500 Subject: [PATCH 3/3] Don't assume bank title is the same as search str because it truncates text --- .../net/runelite/client/plugins/banktags/tabs/TabInterface.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/runelite-client/src/main/java/net/runelite/client/plugins/banktags/tabs/TabInterface.java b/runelite-client/src/main/java/net/runelite/client/plugins/banktags/tabs/TabInterface.java index 4ff70f6ad5..50526c2094 100644 --- a/runelite-client/src/main/java/net/runelite/client/plugins/banktags/tabs/TabInterface.java +++ b/runelite-client/src/main/java/net/runelite/client/plugins/banktags/tabs/TabInterface.java @@ -240,7 +240,7 @@ public class TabInterface } Widget bankTitle = client.getWidget(WidgetInfo.BANK_TITLE_BAR); - if (bankTitle != null && !bankTitle.isHidden()) + if (bankTitle != null && !bankTitle.isHidden() && !str.startsWith(TAG_SEARCH)) { str = bankTitle.getText().replaceFirst("Showing items: ", "");