From 8c3a3cdaa2e03c8f256fff24ccf03f595eab2e0c Mon Sep 17 00:00:00 2001 From: Adam Date: Tue, 21 Aug 2018 10:59:47 -0400 Subject: [PATCH] ge plugin: more reliably show actively traded price Previously whenever searching for the same item twice without closing the interface group it would not show the price of the item due to the lastId not changing. --- .../grandexchange/GrandExchangePlugin.java | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/runelite-client/src/main/java/net/runelite/client/plugins/grandexchange/GrandExchangePlugin.java b/runelite-client/src/main/java/net/runelite/client/plugins/grandexchange/GrandExchangePlugin.java index 3f59fa440d..f4d84e3cce 100644 --- a/runelite-client/src/main/java/net/runelite/client/plugins/grandexchange/GrandExchangePlugin.java +++ b/runelite-client/src/main/java/net/runelite/client/plugins/grandexchange/GrandExchangePlugin.java @@ -63,8 +63,8 @@ import net.runelite.client.input.KeyManager; import net.runelite.client.input.MouseManager; import net.runelite.client.plugins.Plugin; import net.runelite.client.plugins.PluginDescriptor; -import net.runelite.client.ui.NavigationButton; import net.runelite.client.ui.ClientToolbar; +import net.runelite.client.ui.NavigationButton; import net.runelite.client.util.ImageUtil; import net.runelite.client.util.StackFormatter; import net.runelite.client.util.Text; @@ -293,11 +293,19 @@ public class GrandExchangePlugin extends Plugin @Subscribe public void onGameTick(GameTick event) { - if (grandExchangeText == null || grandExchangeItem == null) + if (grandExchangeText == null || grandExchangeItem == null || grandExchangeItem.isHidden()) { return; } + final Widget geText = grandExchangeText; + + if (!geText.getText().contains("Actively traded price")) + { + // searching for the same item twice without closing the search window will cause this. + lastItem = -1; + } + int itemId = grandExchangeItem.getItemId(); if (itemId == OFFER_DEFAULT_ITEM_ID || itemId == -1 @@ -307,7 +315,8 @@ public class GrandExchangePlugin extends Plugin } lastItem = itemId; - final Widget geText = grandExchangeText; + + log.debug("Looking up item {}", itemId); executorService.submit(() -> {