ra/runelite
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

Improve WSClient and party logging

Browse Source 
- Remove duplicate logging from both WSClient and plugins listening for
incoming messages
- Log json instead of deserialized message on receiving message (because
toString might not be properly implemented)

Signed-off-by: Tomas Slusny <slusnucky@gmail.com>
This commit is contained in:
Tomas Slusny
2019-02-06 08:15:47 +01:00
parent 09a7dd7579
commit 8c32614ac5
3 changed files with 2 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
runelite-client/src/main/java/net/runelite/client/plugins/party/PartyPlugin.java
View File

@@ -234,8 +234,6 @@ public class PartyPlugin extends Plugin implements KeyListener
@Subscribe @Subscribe
public void onTilePing(TilePing event) public void onTilePing(TilePing event)
{ {
log.debug("Got tile ping {}", event);
if (config.pings()) if (config.pings())
{ {
pendingTilePings.add(new PartyTilePingData(event.getPoint())); pendingTilePings.add(new PartyTilePingData(event.getPoint()));

2
runelite-client/src/main/java/net/runelite/client/ws/PartyService.java
View File

@@ -114,7 +114,6 @@ public class PartyService
@Subscribe @Subscribe
public void onUserJoin(final UserJoin message) public void onUserJoin(final UserJoin message)
{ {
log.debug("User {} joined", message);
final PartyMember partyMember = new PartyMember(message.getMemberId(), message.getName()); final PartyMember partyMember = new PartyMember(message.getMemberId(), message.getName());
members.add(partyMember); members.add(partyMember);
@@ -130,7 +129,6 @@ public class PartyService
@Subscribe @Subscribe
public void onUserPart(final UserPart message) public void onUserPart(final UserPart message)
{ {
log.debug("User {} left", message);
members.removeIf(member -> member.getMemberId().equals(message.getMemberId())); members.removeIf(member -> member.getMemberId().equals(message.getMemberId()));
} }

4
runelite-client/src/main/java/net/runelite/client/ws/WSClient.java
View File

@@ -173,7 +173,7 @@ public class WSClient extends WebSocketListener implements AutoCloseable
return; return;
} }
log.debug("Got message: {}", message); log.debug("Got: {}", text);
eventBus.post(message); eventBus.post(message);
} }
@@ -187,7 +187,7 @@ public class WSClient extends WebSocketListener implements AutoCloseable
@Override @Override
public void onFailure(WebSocket webSocket, Throwable t, Response response) public void onFailure(WebSocket webSocket, Throwable t, Response response)
{ {
log.warn("Error in websocket", t); log.warn("Error in websocket {}:{}", response, t);
this.webSocket = null; this.webSocket = null;
} }
} }