diff --git a/runelite-client/src/main/java/net/runelite/client/ui/overlay/components/TooltipComponent.java b/runelite-client/src/main/java/net/runelite/client/ui/overlay/components/TooltipComponent.java index 4d606b40ca..2e4b943063 100644 --- a/runelite-client/src/main/java/net/runelite/client/ui/overlay/components/TooltipComponent.java +++ b/runelite-client/src/main/java/net/runelite/client/ui/overlay/components/TooltipComponent.java @@ -24,6 +24,7 @@ */ package net.runelite.client.ui.overlay.components; +import com.google.common.annotations.VisibleForTesting; import java.awt.Color; import java.awt.Dimension; import java.awt.FontMetrics; @@ -96,6 +97,7 @@ public class TooltipComponent implements RenderableEntity char[] chars = line.toCharArray(); int begin = 0; + boolean inTag = false; for (int j = 0; j < chars.length; j++) { if (chars[j] == '<') @@ -110,8 +112,9 @@ public class TooltipComponent implements RenderableEntity lineX += metrics.stringWidth(text); begin = j; + inTag = true; } - else if (chars[j] == '>') + else if (chars[j] == '>' && inTag) { String subLine = line.substring(begin + 1, j); @@ -148,6 +151,7 @@ public class TooltipComponent implements RenderableEntity } begin = j + 1; + inTag = false; } } @@ -162,12 +166,14 @@ public class TooltipComponent implements RenderableEntity return new Dimension(tooltipWidth + OFFSET * 2, tooltipHeight + OFFSET * 2); } - private static int calculateTextWidth(FontMetrics metrics, String line) + @VisibleForTesting + static int calculateTextWidth(FontMetrics metrics, String line) { char[] chars = line.toCharArray(); int textWidth = 0; int begin = 0; + boolean inTag = false; for (int j = 0; j < chars.length; j++) { if (chars[j] == '<') @@ -175,8 +181,9 @@ public class TooltipComponent implements RenderableEntity textWidth += metrics.stringWidth(line.substring(begin, j)); begin = j; + inTag = true; } - else if (chars[j] == '>') + else if (chars[j] == '>' && inTag) { String subLine = line.substring(begin + 1, j); @@ -190,6 +197,7 @@ public class TooltipComponent implements RenderableEntity } begin = j + 1; + inTag = false; } } diff --git a/runelite-client/src/test/java/net/runelite/client/ui/overlay/components/TooltipComponentTest.java b/runelite-client/src/test/java/net/runelite/client/ui/overlay/components/TooltipComponentTest.java new file mode 100644 index 0000000000..f50bf45530 --- /dev/null +++ b/runelite-client/src/test/java/net/runelite/client/ui/overlay/components/TooltipComponentTest.java @@ -0,0 +1,45 @@ +/* + * Copyright (c) 2019, Adam + * All rights reserved. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions are met: + * + * 1. Redistributions of source code must retain the above copyright notice, this + * list of conditions and the following disclaimer. + * 2. Redistributions in binary form must reproduce the above copyright notice, + * this list of conditions and the following disclaimer in the documentation + * and/or other materials provided with the distribution. + * + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND + * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED + * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE + * DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR + * ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES + * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; + * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND + * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS + * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + */ +package net.runelite.client.ui.overlay.components; + +import java.awt.FontMetrics; +import static net.runelite.client.ui.overlay.components.TooltipComponent.calculateTextWidth; +import static org.junit.Assert.assertEquals; +import org.junit.Test; +import static org.mockito.Matchers.anyString; +import static org.mockito.Mockito.mock; +import static org.mockito.Mockito.when; + +public class TooltipComponentTest +{ + @Test + public void testCalculateTextWidth() + { + FontMetrics fontMetics = mock(FontMetrics.class); + when(fontMetics.stringWidth(anyString())).thenAnswer((invocation) -> ((String) invocation.getArguments()[0]).length()); + + assertEquals(11, calculateTextWidth(fontMetics, "line1>line2")); + } +} \ No newline at end of file